Skip to content

Android view props, the onboarding redesign, and root scripts that cover both packages #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronickg merged 3 commits into from
Sep 21, 2026
Merged

Android view props, the onboarding redesign, and root scripts that cover both packages #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0caeb9
Android: Hybrid Views were getting none of their base view props
Sep 21, 2026
e5acc44
The onboarding flow reads as an onboarding, not as a test harness
Sep 21, 2026
835a9a7
The root scripts only knew about one of the two packages
Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,10 @@ scripts/iosrec/IosRec.app/Contents/_CodeSignature/
# not documentation of this library, so they are kept locally rather than
# shipped and reviewed with it.
*-INTERNALS.md

# Screen recordings captured while driving the example app
example/.recordings/

# Native reference apps (UIKit / SwiftUI / Android) used to compare keyboard
# behaviour against. Kept out of the PR like the other internals notes.
native/
1 change: 1 addition & 0 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 22 additions & 4 deletions example/src/navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { FormSheetScreen, NavAScreen, NavBScreen } from './screens/NavigationScr
import { StateChangeScreen } from './screens/StateChangeScreen'
import { KeyboardControllerScreen } from './screens/KeyboardControllerScreen'
import { BenchScreen } from './screens/BenchScreen'
import { ViewPropsReproScreen } from './screens/ViewPropsRepro'
import {
FlowAmountScreen,
FlowEmailScreen,
Expand All @@ -32,10 +33,24 @@ export type RootStackParamList = {
FlowAmount: { impl: Impl }
FlowForm: { impl: Impl }
FlowSheet: { impl: Impl }
ViewPropsRepro: undefined
}

const Stack = createNativeStackNavigator<RootStackParamList>()

/**
* The four onboarding steps share their chrome: no title (the progress rail on
* the screen says which step you are on), a hairline-free header that blends
* into the page, and a back chevron with no label to compete with the headline.
*/
const FLOW_STEP = {
title: '',
headerBackButtonDisplayMode: 'minimal' as const,
headerShadowVisible: false,
headerStyle: { backgroundColor: '#F7F8FA' },
headerTintColor: '#39414E',
}

function HomeScreen() {
const nav = useNavigation<any>()
return (
Expand All @@ -54,6 +69,7 @@ function HomeScreen() {
hint="Four screens end to end — email, amount, a six-field form, then a search sheet. A run is built entirely from one component, so the keyboard behaviour you feel is that component's."
>
<Row>
<Btn testID="home-repro" title="Nitro view props (Android)" onPress={() => nav.navigate('ViewPropsRepro')} />
<Btn testID="home-flow-ours" tone="primary" title="Run flow (NitroInput)" onPress={() => nav.navigate('FlowEmail', { impl: 'ours' })} />
<Btn testID="home-flow-rn" tone="primary" title="Run flow (RN TextInput)" onPress={() => nav.navigate('FlowEmail', { impl: 'rn' })} />
</Row>
Expand Down Expand Up @@ -87,10 +103,11 @@ export function RootNavigator() {
<Stack.Screen name="StateChange" component={StateChangeScreen} options={{ title: 'State change' }} />
<Stack.Screen name="KeyboardController" component={KeyboardControllerScreen} options={{ title: 'keyboard-controller' }} />
<Stack.Screen name="Bench" component={BenchScreen} options={{ title: 'Benchmark' }} />
<Stack.Screen name="FlowEmail" component={FlowEmailScreen} options={{ title: '1 — Sign in' }} />
<Stack.Screen name="FlowAmount" component={FlowAmountScreen} options={{ title: '2 — Amount' }} />
<Stack.Screen name="FlowForm" component={FlowFormScreen} options={{ title: '3 — Details' }} />
<Stack.Screen name="FlowEmail" component={FlowEmailScreen} options={FLOW_STEP} />
<Stack.Screen name="FlowAmount" component={FlowAmountScreen} options={FLOW_STEP} />
<Stack.Screen name="FlowForm" component={FlowFormScreen} options={FLOW_STEP} />
<Stack.Screen name="Demo" component={DemoScreen} options={{ title: 'Demo' }} />
<Stack.Screen name="ViewPropsRepro" component={ViewPropsReproScreen} options={{ title: 'View props' }} />
<Stack.Screen
name="FlowSheet"
component={FlowSheetScreen}
Expand All @@ -99,7 +116,8 @@ export function RootNavigator() {
sheetAllowedDetents: [0.6, 0.95],
sheetGrabberVisible: true,
sheetCornerRadius: 20,
title: '4 — Search',
title: '',
headerShown: false,
}}
/>
<Stack.Screen
Expand Down
Loading