[RF] Prepare RooFit and HistFactory for ROOT without implicit ownership#20889
Closed
hageboeck wants to merge 1 commit intoroot-project:masterfrom
Closed
[RF] Prepare RooFit and HistFactory for ROOT without implicit ownership#20889hageboeck wants to merge 1 commit intoroot-project:masterfrom
hageboeck wants to merge 1 commit intoroot-project:masterfrom
Conversation
2 tasks
hageboeck
commented
Jan 14, 2026
Test Results 22 files 22 suites 3d 15h 8m 25s ⏱️ Results for commit 574a505. ♻️ This comment has been updated with latest results. |
hageboeck
force-pushed
the
root7-ownership-2
branch
from
c4c7870 to
efc07d6
Compare
hageboeck
force-pushed
the
root7-ownership-2
branch
from
efc07d6 to
7e33583
Compare
hageboeck
force-pushed
the
root7-ownership-2
branch
2 times, most recently
from
b880a72 to
fb69847
Compare
hageboeck
force-pushed
the
root7-ownership-2
branch
from
fb69847 to
225dfac
Compare
Also add an assertion to stop the test when executed in the wrong directory. Previously, the test would crash.
hageboeck
force-pushed
the
root7-ownership-2
branch
from
225dfac to
574a505
Compare
guitargeek
approved these changes
Jan 21, 2026
Member
Author
|
Github won't let me merge, because there's a supposedly unresolved comment that cannot be resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes a few RooFit-related commits out of #18083.
The backend-related commit fixes the tests in case root has been configured withWent to [RF] Don't fall back to default backend for codegen_no_grad if clad=OFF #20890-Dclad=off.Note: