[ntuple] Throw instead of asserting in RMiniFileReader::ReadBuffer#20986
Merged
silverweed merged 1 commit intoroot-project:masterfrom Jan 26, 2026
Merged
Conversation
jblomer
approved these changes
Jan 22, 2026
Test Results 22 files 22 suites 3d 11h 1m 19s ⏱️ For more details on these failures, see this check. Results for commit 6ef9cda. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
rminifile_readbuffer_noassert
branch
from
e742851 to
6ef9cda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrupted files may cause
ReadBufferto fail, so the proper way of handling it is by returning aRResultrather than asserting.In the interest of not changing the many places using
ReadBuffer, I made it wrap aTryReadBufferfunction that returnsRResultand simply callThrowOnErroron it.This gives similar semantics as before, except
ReadBufferwill throw rather than asserting.