new branch #850
Open
new branch #850
+59
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use range of wikiword to guide highlighting test. * Require wikiword to exist. * Create wikiwords in tests that is using hywiki-tests--word-at. * Let hywiki-tests--run-test-case start from state in buffer so test cases can prepare it. If buffer needs to be empty use erase-buffer. * Drop interactive requirement on tests that does not require it any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Request to merge on master branch instead of rsw. Should be same as
#849 with an update of the ChangeLog.
Why
rsw branch was merged to master so work can continue there (or here
if you prefer) instead.
Includes further improvements. More tests are working now.
I also rolled back to the previous version of hywiki-tests--word-at
and made it so that if hywiki-word-at finds a wikiword then if we test
highlighting it must also find a wikiword. So that not missing
highlighting indicates there is no wikiword.
That rollback causes a test to fail. I think this points to a problem
in hywiki rather than in the test so I have marked it as expected
failed.