Skip to content

ci: use reusable workflows from plugin-skeleton-d - #326

Merged
justlevine merged 5 commits into
mainfrom
ci/use-skeleton-workflows
Oct 5, 2026
Merged

justlevine merged 5 commits into
mainfrom
ci/use-skeleton-workflows

Conversation

@justlevine

@justlevine justlevine commented Oct 4, 2026 •

Copy link
Copy Markdown
Collaborator

What

Consumes the workflows from plugin-skeleton-d

Why

Avoid maintaining multiple copies and prepare for the adoption of wp-shared-workflows.

Related Issue(s):

How

AI Disclosure

Testing Instructions

Screenshots

Additional Info

Checklist

  • I have read the Contribution Guidelines.
  • I have read the Development Guidelines.
  • I have added necessary tests to cover my changes.
  • I have updated the project documentation as needed.
  • My code has detailed inline documentation.
  • My code is tested to the best of my abilities.
  • My code passes all lints, tests, and checks.

Copilot AI balanced review requested due to automatic review settings October 4, 2026 18:10
@codecov-commenter

codecov-commenter commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.83%. Comparing base (fc2a32d) to head (9b26976).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #326      +/-   ##
============================================
- Coverage     89.42%   87.83%   -1.60%     
  Complexity      667      667              
============================================
  Files            23       33      +10     
  Lines          2298     2951     +653     
  Branches          0      180     +180     
============================================
+ Hits           2055     2592     +537     
- Misses          243      297      +54     
- Partials          0       62      +62     
Flag Coverage Δ
jest 82.23% <ø> (?)
unit 89.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Actionlint is always skipped, and Playground publishing lacks permission to read build artifacts.

Review effort: Balanced
Findings: 2 Medium severity · 1 Low severity

Open (3)
What changed in this PR

Centralizes CI implementation in SHA-pinned plugin-skeleton-d reusable workflows.

Changes:

  • Replaces local reusable workflows with shared upstream workflows.
  • Adds secure Playground publishing and PR artifact cleanup flows.
  • Updates workflow documentation.
File Description
docs/​DEVELOPMENT.md Updates the Playground workflow link.
.github/​workflows/​wp-playground-pr-preview.yml Adds post-CI preview publishing.
.github/​workflows/​reusable-wp-playground-pr-preview.yml Removes the local preview workflow.
.github/​workflows/​reusable-phpunit.yml Removes the local PHPUnit workflow.
.github/​workflows/​reusable-phpstan.yml Removes the local PHPStan workflow.
.github/​workflows/​reusable-phpcs.yml Removes the local PHPCS workflow.
.github/​workflows/​reusable-lint-css-js.yml Removes the local frontend lint workflow.
.github/​workflows/​reusable-jest.yml Removes the local Jest workflow.
.github/​workflows/​reusable-e2e.yml Removes the local E2E workflow.
.github/​workflows/​reusable-build.yml Removes the local build workflow.
.github/​workflows/​release.yml Uses the shared build workflow for releases.
.github/​workflows/​README.md Documents the centralized CI architecture.
.github/​workflows/​pr-cleanup.yml Adds closed-PR artifact cleanup.
.github/​workflows/​ci.yml Migrates CI jobs and adds actionlint.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/wp-playground-pr-preview.yml
Comment thread .github/workflows/README.md Outdated
Copilot AI balanced review requested due to automatic review settings October 4, 2026 19:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Privileged preview and cleanup workflows only become fully testable after merging into the default branch.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
Resolved since last review (2)

Copilot AI balanced review requested due to automatic review settings October 4, 2026 19:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Cleanup can cancel runs and delete artifacts belonging to another PR that uses the same head branch.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
Resolved since last review (1)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Filter cleanup runs by PR number

.github/​workflows/​pr-cleanup.yml:20

The shared cleanup workflow selects runs only by head-ref and head-repo-id, not by pr-number. Because this repository accepts PRs to both main and release/**, the same head branch can back two open PRs; closing either one will cancel active runs and delete Actions artifacts for both. The upstream workflow should filter each run to the closing PR number before this cleanup is enabled.

Comment thread .github/workflows/README.md Outdated
Removed mention of broken build skipping PHPUnit and E2E checks.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 4, 2026 19:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The pinned workflow interfaces, caller inputs, permissions, and accompanying documentation are consistent.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Copilot AI balanced review requested due to automatic review settings October 4, 2026 20:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The privileged preview and cleanup workflows only become testable from the default branch after merging.

Review effort: Balanced
Findings: None

@justlevine
justlevine requested a review from Kallyan01 October 4, 2026 20:26
@justlevine
justlevine merged commit c9314ec into main Oct 5, 2026
19 checks passed
@justlevine
justlevine deleted the ci/use-skeleton-workflows branch October 5, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants