HOLD: Allow workshop log owners to edit their logs (waiting for workshop_log refactor)#1363
Draft
HOLD: Allow workshop log owners to edit their logs (waiting for workshop_log refactor)#1363
Conversation
The edit? policy action was not defined in WorkshopLogPolicy, so it fell through to ApplicationPolicy#manage? (admin-only). Owners could update via the controller but never saw the Edit button or reached the edit form. Adding edit? with the same rule as update? fixes this. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
edit?policy action was missing fromWorkshopLogPolicy, so it fell through toApplicationPolicy#manage?which is admin-onlyupdate?action already allowed owners, creating an inconsistencyHow did you approach the change?
edit?method toWorkshopLogPolicywith the sameadmin? || owner?rule asupdate?allowed_to?(:edit?, log)WorkshopLogPolicyspec coveringedit?andupdate?for admin, owner, other user, and anonymous contextsUI Testing Checklist
Anything else to add?
allowed_to?(:edit?, ...)guards — this was purely a policy gap🤖 Generated with Claude Code