Skip to content

Add publishing test results to workflow#1423

Open
lenikadali wants to merge 1 commit intomainfrom
publish-test-coverage-reports
Open

Add publishing test results to workflow#1423
lenikadali wants to merge 1 commit intomainfrom
publish-test-coverage-reports

Conversation

@lenikadali
Copy link
Collaborator

Added publishing of test results to workflow

Closes #594

What is the goal of this PR and why is this important?

As part of discussions regarding #594, it was agreed that we publish test results as part of AWBW's CI pipeline runs.
Code coverage results are being published as a result of merging #110 and this PR builds on that work.

How did you approach the change?

I did some research regarding how publishing of test results is handled in other open source Rails projects and picked what I thought would work for the project at its current stage. Some notes regarding what I didn't include:

  1. Publishing of Capybara reports
    I haven't added Capybara because it presently isn't being run in the current pipeline.
    Would we want to save screenshots of failed feature tests? In which case I would be happy to add running them to the pipeline and saving the screenshot results as part of the workflow.

  2. In CI pipeline for AWBW #55 (parent of GitHub actions for ci/cd (partially tracked by CI pipeline for AWBW #55) #594), there is the following to-do item

  • Runs the tests in an environment as similar to production as possible (e.g. if CD results in Docker images being deployed then try to run the tests inside of a similar Docker image)
    From looking at the current codebase, I saw a a Capfile, a Dockerfile and a Procfile for development. With this under consideration, what would "an environment as similar to production as possible" mean?

It may be that current pipeline suffices and we can validate as we go depending on need e.g. having a workflow for building and publishing a Dockerfile.

Anything else to add?

Reviewer's Note: I put the changes in the sanity-check-main.yml file since that's where the code coverage job is but most projects seem to put it in ci.yml. Let me know if I should keep the changes as is or move them to ci.yml.

Thanks in advance for the review 🙏 😊

Added publishing of test results to workflow
@lenikadali lenikadali requested a review from maebeale March 13, 2026 12:50
@maebeale
Copy link
Collaborator

Thank you, @lenikadali !

  1. No need to save capybara pics as part of CI. They do get saved in tmp and that's fine.
  2. I'll ask @jmilljr24 re answering this

Re sanity-check vs ci.yml, my vote is to move things to ci.yml so we're more standard.

@jmilljr24
Copy link
Collaborator

  1. The production server on DigitalOcean App Platform is built from our Dockerfile. I can't speak on what's best regarding testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub actions for ci/cd (partially tracked by CI pipeline for AWBW #55)

3 participants