Open
Conversation
Added publishing of test results to workflow
Collaborator
|
Thank you, @lenikadali !
Re sanity-check vs ci.yml, my vote is to move things to ci.yml so we're more standard. |
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added publishing of test results to workflow
Closes #594
What is the goal of this PR and why is this important?
As part of discussions regarding #594, it was agreed that we publish test results as part of AWBW's CI pipeline runs.
Code coverage results are being published as a result of merging #110 and this PR builds on that work.
How did you approach the change?
I did some research regarding how publishing of test results is handled in other open source Rails projects and picked what I thought would work for the project at its current stage. Some notes regarding what I didn't include:
Publishing of Capybara reports
I haven't added Capybara because it presently isn't being run in the current pipeline.
Would we want to save screenshots of failed feature tests? In which case I would be happy to add running them to the pipeline and saving the screenshot results as part of the workflow.
In CI pipeline for AWBW #55 (parent of GitHub actions for ci/cd (partially tracked by CI pipeline for AWBW #55) #594), there is the following to-do item
It may be that current pipeline suffices and we can validate as we go depending on need e.g. having a workflow for building and publishing a
Dockerfile.Anything else to add?
Reviewer's Note: I put the changes in the
sanity-check-main.ymlfile since that's where the code coverage job is but most projects seem to put it inci.yml. Let me know if I should keep the changes as is or move them toci.yml.Thanks in advance for the review 🙏 😊