MAYBE: Drop benign SolidQueue shutdown connection errors from Honeybadger - #2192
Open
maebeale wants to merge 1 commit into
Open
MAYBE: Drop benign SolidQueue shutdown connection errors from Honeybadger#2192maebeale wants to merge 1 commit into
maebeale wants to merge 1 commit into
Conversation
A terminating worker pod raises ActiveRecord::ConnectionNotEstablished (TRILOGY_CLOSED_CONNECTION) in at_exit while deregistering its SolidQueue Process record after the DB pool has closed. It pages on every deploy/restart, affects no users, and loses no work. Halt only closed-connection errors raised outside any request so genuine mid-request DB outages still report. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
marked this pull request as ready for review
August 13, 2026 22:59
jmilljr24
reviewed
Aug 14, 2026
jmilljr24
left a comment
jmilljr24
left a comment
Collaborator
There was a problem hiding this comment.
Same comment as before on the other error. This is the first seeing it. I don't know what this code does but I know honeybadger is wrapped around basically everything so if this is incorrect it could take the whole site down.
I'll accept a tiny bit of noise on the hb notifications.
maebeale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 small before_notify filter with one guard condition, plus unit spec
What & why
ActiveRecord::ConnectionNotEstablished(TRILOGY_CLOSED_CONNECTION) inat_exitwhile SolidQueue deregisters itsProcessrecord after the DB pool has closed. Pages on every deploy/restart, 0 users affected, nothing lost.before_notifyhook that halts these — but only when raised outside any request (componentblank), so a genuine mid-request/job DB outage still reports.Notes
terminationGracePeriod/ stop ordering) left out as riskier; suppression first.