Skip to content

add balloon-popper#10438

Closed
atapifire wants to merge 5 commits intorunelite:masterfrom
atapifire:add-balloon-popper
Closed

add balloon-popper#10438
atapifire wants to merge 5 commits intorunelite:masterfrom
atapifire:add-balloon-popper

Conversation

@atapifire
Copy link
Copy Markdown

This is a new plugin for tracking Party Room balloons.

@pajlada
Copy link
Copy Markdown
Contributor

pajlada commented Feb 3, 2026

Hi, this is not how you submit a plugin to the plugin hub. Please see https://github.com/runelite/plugin-hub for instructions.

@pajlada pajlada added the invalid This doesn't seem right label Feb 3, 2026
@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 3, 2026
@runelite-github-app runelite-github-app Bot added size-0 and removed waiting for author waiting for the pr author to make changes or respond to questions labels Feb 3, 2026
@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Feb 3, 2026

@pajlada pajlada removed the invalid This doesn't seem right label Feb 3, 2026
@atapifire
Copy link
Copy Markdown
Author

Plugin Submission Summary

This PR adds the Balloon Popper plugin to the RuneLite Plugin Hub.

What This Plugin Does

Tracks balloons popped in the Party Room and displays them as custom "Party Skill" XP (replacing the unused Sailing skill label). Features include:

  • Dynamic XP tracking with level-up effects (fireworks, sound, dialog)
  • In-game sidebar with collection log tracking
  • Automatic item normalization for noted items
  • Quantity tracking for all collected items

Changes Made in This Submission

Initial submission (commit 9420ec5):

  • Incorrectly used JSON format for manifest
  • Used core RuneLite package namespace (net.runelite.client.plugins)

Updated submission (commit dfdf575):

  • ✅ Refactored to unique package: com.atapifire.balloonpopper
  • ✅ Corrected manifest to plain text key=value format
  • ✅ Removed .json extension from manifest filename
  • ✅ Added required plugins field to runelite-plugin.properties
  • ✅ Added pluginMainClass to build.gradle

Compliance Checklist

  • ✅ BSD 2-Clause License included
  • ✅ README.md with plugin description
  • ✅ Proper package naming (not in net.runelite.client)
  • ✅ Plugin properties file with all required fields
  • ✅ Resources loaded via getResourceAsStream() (not getResource())
  • ✅ No third-party dependencies
  • ✅ Does not violate Jagex's 3rd party client rules (no automation, no unfair advantages)

The plugin is ready for review. Please let me know if any additional changes are needed.

@riktenx riktenx changed the title Add balloon-popper.json configuration file add balloon-popper Feb 3, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented Feb 7, 2026

your build.gradle is complete nonsense. it should just be what's in https://github.com/runelite/example-plugin

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 7, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented Feb 28, 2026

closing because this submission is still broken, if you fix it you can submit a new PR

@riktenx riktenx closed this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin added size-0 waiting for author waiting for the pr author to make changes or respond to questions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants