Neon fast path for str::contains#152176
Open
JamieCunliffe wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
Collaborator
Member
|
I can't vouch for correctness. @rustbot reroll |
Member
How do you know? Did we run benchmarks (can you provide the results)? |
Contributor
Author
|
I didn't see any benchmarks for this in tree but I did write a few quick ones, something such as: let data = "Lorem ipsum dolor sit amet";
c.bench_function("amet", |b| b.iter(|| black_box("amet".is_contained_in(&data))));Nightly: [41.489 ns 41.512 ns 41.534 ns] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the SIMD friendly version of the function also gives a decent speed up with Neon.