Skip to content

triagebot: notify on diagnostic attribute changes#155384

Open
mejrs wants to merge 1 commit intorust-lang:mainfrom
mejrs:pingme
Open

triagebot: notify on diagnostic attribute changes#155384
mejrs wants to merge 1 commit intorust-lang:mainfrom
mejrs:pingme

Conversation

@mejrs
Copy link
Copy Markdown
Contributor

@mejrs mejrs commented Apr 16, 2026

Did I get this right? 😆

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 16, 2026

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 16, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, @jieyouxu
  • @Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu
  • Random selection from Mark-Simulacrum, jieyouxu

jieyouxu
jieyouxu approved these changes Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? me @bors r+ rollup

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 16, 2026

📌 Commit 5163536 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 16, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2026
@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 16, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 16, 2026

⚠️ A new commit 4645f036d054cbc083194deb8d69c57cd3cd8317 was pushed.

This pull request was unapproved.

@mejrs
Copy link
Copy Markdown
Contributor Author

mejrs commented Apr 16, 2026

Sorry, I realized the wording was not quite right.

@bors r=jieyouxu

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 16, 2026

📌 Commit 4645f03 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 16, 2026
@JonathanBrouwer
Rollup merge of rust-lang#155384 - mejrs:pingme, r=jieyouxu
e80fd0e 
triagebot: notify on diagnostic attribute changes

Did I get this right? 😆
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 16, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 16, 2026
@JonathanBrouwer
Rollup merge of rust-lang#155384 - mejrs:pingme, r=jieyouxu
b3c998a 
triagebot: notify on diagnostic attribute changes

Did I get this right? 😆
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 16, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mejrs @rustbot @jieyouxu @Mark-Simulacrum