Implement VecDeque::truncate_to_range#156220
Open
cammeresi wants to merge 2 commits intorust-lang:mainfrom
Open
Implement VecDeque::truncate_to_range#156220cammeresi wants to merge 2 commits intorust-lang:mainfrom
VecDeque::truncate_to_range#156220cammeresi wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-libs
Collaborator
|
r? @nia-e rustbot has assigned @nia-e. Use Why was this reviewer chosen?The reviewer was selected based on:
|
qaijuang
reviewed
May 6, 2026
| Some(c) => { | ||
| let _g_a = Dropper(&mut *drop_a); | ||
| let _g_b = Dropper(&mut *drop_b); | ||
| ptr::drop_in_place(c); |
Contributor
There was a problem hiding this comment.
without dropper, won't this leak on panic ? same for line 1537
qaijuang
reviewed
May 6, 2026
| let bptr = back.as_mut_ptr(); | ||
|
|
||
| unsafe { | ||
| let (drop_a, drop_b, drop_c) = if end <= flen { |
Contributor
There was a problem hiding this comment.
Would it make sense to add a fast path for types that don’t need dropping? Something like:
around line 1493
if !mem::needs_drop::<T>() {
self.head = self.to_physical_idx(start);
self.len = end - start;
return;
}what do you think ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #156215