Refactor Type::size field to TypeId::size method for type_info#156223
Open
SpriteOvO wants to merge 2 commits intorust-lang:mainfrom
Open
Refactor Type::size field to TypeId::size method for type_info#156223SpriteOvO wants to merge 2 commits intorust-lang:mainfrom
Type::size field to TypeId::size method for type_info#156223SpriteOvO wants to merge 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
The reflection data structures are tied exactly to the implementation cc @oli-obk Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr Some changes occurred to the CTFE machinery Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri |
rustbot
added
S-waiting-on-review
SpriteOvO
added
F-type_info
oli-obk
reviewed
May 6, 2026
oli-obk
reviewed
May 6, 2026
SpriteOvO
force-pushed
the
type-info-refactor-size
branch
from
fa025e2 to
72d15e1
Compare
rustbot
added
T-compiler
SpriteOvO
added
the
S-waiting-on-review
This comment was marked as off-topic.
This comment was marked as off-topic.
RalfJung
reviewed
May 6, 2026
| } | ||
|
|
||
| /// Equivalent to `project_downcast`, but identifies the variant by name instead of index. | ||
| pub fn project_downcast_sym<P: Projectable<'tcx, M::Provenance>>( |
Member
There was a problem hiding this comment.
I'd suggest calling this project_downcast_named or so. In Miri we have something similar for fields, called project_field_named, which maybe we should upstream.
This comment was marked as off-topic.
This comment was marked as off-topic.
oli-obk
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue #146922
r? @oli-obk