Skip to content

move more compiler crates away from box_patterns #156287

Merged
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom
cyrgani:unbox-2
May 12, 2026
Merged

move more compiler crates away from box_patterns #156287
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom
cyrgani:unbox-2

Conversation

@cyrgani
Copy link
Copy Markdown
Contributor

@cyrgani cyrgani commented May 7, 2026

Part of #156110.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 7, 2026

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

Some changes occurred in rustc_ty_utils::consts.rs

cc @BoxyUwU

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

Some changes occurred to constck

cc @fee1-dead

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 7, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 7, 2026

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 19 candidates

@cyrgani cyrgani mentioned this pull request May 7, 2026
Open
6 tasks
@cyrgani
Copy link
Copy Markdown
Contributor Author

cyrgani commented May 7, 2026

This might need to wait a few days so that rust-lang/rust-analyzer#22292 becomes part of the next r-a release, not sure how exactly that works.

@petrochenkov
Copy link
Copy Markdown
Contributor

petrochenkov commented May 7, 2026

r=me after the next rust-analyzer release.
@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@cyrgani
Copy link
Copy Markdown
Contributor Author

cyrgani commented May 11, 2026

New release is out: https://github.com/rust-lang/rust-analyzer/releases/tag/2026-05-11.
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels May 11, 2026
@petrochenkov
Copy link
Copy Markdown
Contributor

petrochenkov commented May 12, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 12, 2026

📌 Commit a060379 has been approved by petrochenkov

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 12, 2026
@JonathanBrouwer
Rollup merge of rust-lang#156287 - cyrgani:unbox-2, r=petrochenkov
dfe68e9 
move more compiler crates away from `box_patterns`

Part of rust-lang#156110.
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 12, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request May 12, 2026
@bors
Auto merge of #156503 - JonathanBrouwer:rollup-MgaiQc4, r=JonathanBro…
15de518 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #156287 (move more compiler crates away from `box_patterns` )
 - #156385 (std::net::tcp: let the OS pick the port numbers)
 - #156145 (Move tests cast)
 - #156502 (Give an example of a Ctor in the doc-comments)
rust-bors Bot pushed a commit that referenced this pull request May 12, 2026
@bors
Auto merge of #156503 - JonathanBrouwer:rollup-MgaiQc4, r=JonathanBro…
d235757 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #156287 (move more compiler crates away from `box_patterns` )
 - #156385 (std::net::tcp: let the OS pick the port numbers)
 - #156145 (Move tests cast)
 - #156502 (Give an example of a Ctor in the doc-comments)
rust-bors Bot pushed a commit that referenced this pull request May 12, 2026
@bors
Auto merge of #156503 - JonathanBrouwer:rollup-MgaiQc4, r=JonathanBro…
48b6cc6 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #156287 (move more compiler crates away from `box_patterns` )
 - #156385 (std::net::tcp: let the OS pick the port numbers)
 - #156145 (Move tests cast)
 - #156502 (Give an example of a Ctor in the doc-comments)
rust-bors Bot pushed a commit that referenced this pull request May 12, 2026
@bors
Auto merge of #156503 - JonathanBrouwer:rollup-MgaiQc4, r=JonathanBro…
539c1de 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #156287 (move more compiler crates away from `box_patterns` )
 - #156385 (std::net::tcp: let the OS pick the port numbers)
 - #156145 (Move tests cast)
 - #156502 (Give an example of a Ctor in the doc-comments)
rust-bors Bot pushed a commit that referenced this pull request May 12, 2026
@bors
Auto merge of #156503 - JonathanBrouwer:rollup-MgaiQc4, r=JonathanBro…
77d28c7 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #156287 (move more compiler crates away from `box_patterns` )
 - #156385 (std::net::tcp: let the OS pick the port numbers)
 - #156145 (Move tests cast)
 - #156502 (Give an example of a Ctor in the doc-comments)
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 12, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request May 12, 2026
@bors
Auto merge of #156506 - JonathanBrouwer:rollup-sOIgP3l, r=JonathanBro…
561d401 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #156287 (move more compiler crates away from `box_patterns` )
 - #156428 (Move `std::io::Cursor` to `core::io`)
 - #156431 (Move `std::io::util` to `core::io`)
 - #156145 (Move tests cast)
 - #156284 (resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets)
 - #156502 (Give an example of a Ctor in the doc-comments)
rust-bors Bot pushed a commit that referenced this pull request May 12, 2026
@bors
Auto merge of #156506 - JonathanBrouwer:rollup-sOIgP3l, r=JonathanBro…
8b03437 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #156287 (move more compiler crates away from `box_patterns` )
 - #156428 (Move `std::io::Cursor` to `core::io`)
 - #156431 (Move `std::io::util` to `core::io`)
 - #156145 (Move tests cast)
 - #156284 (resolve: Fix a false positive "cannot reexport" error for ambiguous glob sets)
 - #156502 (Give an example of a Ctor in the doc-comments)
@rust-bors rust-bors Bot merged commit 4ce7ac1 into rust-lang:main May 12, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone May 12, 2026
rust-timer added a commit that referenced this pull request May 12, 2026
@rust-timer
Unrolled build for #156287
cbc74ce 
Rollup merge of #156287 - cyrgani:unbox-2, r=petrochenkov

move more compiler crates away from `box_patterns`

Part of #156110.
@cyrgani cyrgani deleted the unbox-2 branch May 13, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cyrgani @rustbot @petrochenkov