Revise index / reset / skip methods #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Make
fn indexprivate; addfn word_offsetas a pub replacement.Remove
fn reset; renamefn generate_and_settoreset_and_skip.Motivation
The old
fn indexwas easy to mis-use: RustCrypto/stream-ciphers#438 (comment). I don't think this was the first time.We also don't need two "reset" methods; it should be equivalent to call
reset_and_skip(0).@nstilt1 please review.