Skip to content

Conversation

@dhardy
Copy link
Member

@dhardy dhardy commented Jan 12, 2026

  • Added a CHANGELOG.md entry

Summary

Make fn index private; add fn word_offset as a pub replacement.

Remove fn reset; rename fn generate_and_set to reset_and_skip.

Motivation

The old fn index was easy to mis-use: RustCrypto/stream-ciphers#438 (comment). I don't think this was the first time.

We also don't need two "reset" methods; it should be equivalent to call reset_and_skip(0).

@nstilt1 please review.

@dhardy dhardy requested a review from newpavlov January 12, 2026 07:44
@dhardy
Copy link
Member Author

dhardy commented Jan 13, 2026

From the other PR and patch I take it that @nstilt1 finds this acceptable.

@dhardy dhardy merged commit eca8fcc into master Jan 13, 2026
13 checks passed
@dhardy dhardy deleted the push-xzmlvzwurnrl branch January 13, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants