Handle zero-sized buffers internally #295
Draft
+439
−471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
DS - Android NDK
DS - CoreGraphics
madsmtm
force-pushed
the
madsmtm/support-zero-sized
branch
2 times, most recently
from
5806393 to
76304d2
Compare
madsmtm
removed
DS - Android NDK
DS - CoreGraphics
madsmtm
force-pushed
the
madsmtm/support-zero-sized
branch
2 times, most recently
from
f94ac8b to
25462b5
Compare
And default to a 0-sized buffer instead of panicking in `buffer_mut`.
madsmtm
force-pushed
the
madsmtm/support-zero-sized
branch
from
25462b5 to
1c25210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
u32in our public API instead ofNonZeroU32, and handlewidth == 0 || height == 0internally. This resolves #238. Note that there are still a few inconsistencies between platforms in how things are rendered when the buffer is smaller than the window, but that is pre-existing, see #177.We can now also default to a 0-sized buffer instead of panicking in
buffer_mut, which resolves #106.Tested on: