Skip to content

Remove unnecessary generics from Buffer<'_> #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
madsmtm wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove unnecessary generics from Buffer<'_> #307

madsmtm wants to merge 3 commits into from

Conversation

@madsmtm
Copy link
Member

@madsmtm madsmtm commented Jan 14, 2026

This should make it more ergonomic to pass around.

@madsmtm
bench: Test actual rendering time
fc8968e 
This helps evaluate how well `.pixels_mut()` is inlined and such.
@madsmtm madsmtm added the enhancement New feature or request label Jan 14, 2026
@madsmtm madsmtm added this to the Softbuffer v0.5 milestone Jan 14, 2026
@madsmtm madsmtm force-pushed the madsmtm/remove-buffer-generics branch 2 times, most recently from e3b4a30 to 1fe0c88 Compare January 14, 2026 11:37
@madsmtm madsmtm force-pushed the madsmtm/remove-buffer-generics branch from 1fe0c88 to d6320a6 Compare January 14, 2026 11:45
@MarijnS95
Copy link
Member

MarijnS95 commented Jan 15, 2026

Fortunately backend_dispatch already allowed to omit these on specific backends (https://github.com/MarijnS95/softbuffer/compare/android-surfacecontrol), but it's good to make them disappear from the public API too in light of having a separate buffer creation API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Milestone

Softbuffer v0.5

Development

Successfully merging this pull request may close these issues.

3 participants

@madsmtm @MarijnS95