[master] Access pillar data while rendering pillars#64043
Open
dwoz wants to merge 16 commits intosaltstack:masterfrom
Open
[master] Access pillar data while rendering pillars#64043dwoz wants to merge 16 commits intosaltstack:masterfrom
dwoz wants to merge 16 commits intosaltstack:masterfrom
Conversation
This was referenced Apr 8, 2023
s0undt3ch
previously approved these changes
Apr 8, 2023
Contributor
|
An interesting thought I had was that it's probably not even necessary to call >>> mods = salt.loader.minion_mods(opts, utils=utils)
>>> mods.pack["__pillar__"]
{'foo': 'bar', 'baz': 123}
>>> mods["pillar.get"]("foo")
'bar'
>>> mods["pillar.get"]("baz")
123
>>> mods["pillar.get"]("aaaaaa")
''
>>> opts["pillar"].update({"aaaaaa": 5555})
>>> mods.pack["__pillar__"] = opts["pillar"]
>>> mods["pillar.get"]("aaaaaa")
5555 |
frebib
reviewed
Jul 6, 2023
Contributor
|
Yep, I can confirm that with some tweaks this does solve the same problem as my patch, but in a much less shitty way. Thanks @dwoz |
444dc4b to
21c5873
Compare
36ef0c3 to
673960b
Compare
s0undt3ch
previously requested changes
Apr 8, 2024
Contributor
|
Looks like the failing tests are valid |
twangboy
previously approved these changes
Jul 3, 2025
twangboy
previously approved these changes
Apr 6, 2026
…_ and explicitly update pack
…oken circular references
…egration tests pass locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pillar dunder is now available in extension modules during pillar render
Fixes: #65724
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.