Skip to content

add open_htj2k_support#9

Open
osamu620 wants to merge 4 commits into
sandflow:mainfrom
osamu620:add_open_htj2k
Open

add open_htj2k_support#9
osamu620 wants to merge 4 commits into
sandflow:mainfrom
osamu620:add_open_htj2k

Conversation

@osamu620
Copy link
Copy Markdown
Contributor

@osamu620 osamu620 commented May 24, 2022

related to #3

Comment thread src/main/cpp/ohtj2k_codec.cpp Outdated
Comment thread src/main/cpp/ohtj2k_codec.cpp Outdated
@palemieux
Copy link
Copy Markdown
Contributor

@osamu620 Does OpenHTJ2K require Cxx17 by any chance?

Compilation dies on #include <filesystem>

@osamu620
Copy link
Copy Markdown
Contributor Author

@osamu620 Does OpenHTJ2K require Cxx17 by any chance?

Compilation dies on #include <filesystem>

Yes. The threadpool class uses C++17 features.

@palemieux
Copy link
Copy Markdown
Contributor

@osamu620 Does OpenHTJ2K require Cxx17 by any chance?

Compilation dies on #include <filesystem>

Yes. The threadpool class uses C++17 features.

Which version of GCC should I use?

@palemieux
Copy link
Copy Markdown
Contributor

@osamu620 Does OpenHTJ2K require Cxx17 by any chance?

Compilation dies on #include <filesystem>

Yes. The threadpool class uses C++17 features.

Which version of GCC should I use?

It looks like GCC10 should work.

@osamu620
Copy link
Copy Markdown
Contributor Author

@palemieux
I have confirmed GCC10 (gcc-10 (Ubuntu 10.3.0-15ubuntu1) 10.3.0) works.

@palemieux
Copy link
Copy Markdown
Contributor

@osamu620 j2k_ht_ohtj2k fails on RGBA images

./build/libench j2k_ht_ohtj2k src/test/resources/images/rgba.png

@palemieux
Copy link
Copy Markdown
Contributor

@osamu620 Can you add j2k_ht_ohtj2k to the Python script:

f0aa58d

@michaeldsmith
Copy link
Copy Markdown
Collaborator

why not just add this line to CMakeLists.txt to require C++ 17 for all platforms?

set(CMAKE_CXX_STANDARD 17)

@palemieux
Copy link
Copy Markdown
Contributor

why not just add this line to CMakeLists.txt to require C++ 17 for all platforms?

Not all Linux distributions ship with a GCC toolchain that support C++ 17.

osamu620 and others added 2 commits May 25, 2022 17:52
@osamu620
Copy link
Copy Markdown
Contributor Author

@palemieux @michaeldsmith
A bug on RGBA images in OpenHTJ2K is fixed. And I have modified some C++17 or C++14-specific features. Now, C++11 compilers can compile OpenHTJ2K.

@palemieux
Copy link
Copy Markdown
Contributor

@osamu620 You might have forgotten to update the OpenHTJ2K submodule. Also, the library outputs Tile num x = 1, y = 1 repeatedly to stdout. How can the latter be suppressed?

- Remove decoder message that is not useful
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants