Adding line separator for "version number" and "or newer" in version picker#318
Draft
rhit-silkaijr wants to merge 4 commits intomasterfrom
Draft
Adding line separator for "version number" and "or newer" in version picker#318rhit-silkaijr wants to merge 4 commits intomasterfrom
rhit-silkaijr wants to merge 4 commits intomasterfrom
Conversation
rhit-silkaijr
requested review from
rhit-daughewd,
rhit-mooretj and
rhit-zhangl8
Member
|
The current version already has a separator line, I think we just forgot to close the linked issue when adding the line a couple of days later (1e145ab). I don't remember receiving new requests for making the version selector more clear after that, so I think making the separator a thick green bar is unnecessary. Current: PR: |
Member
|
My vote is to stick with the previous thin gray line and fix its spacing for longer version numbers |
budak7273
requested changes
Nov 19, 2025
github-project-automation
bot
moved this from 🆕 New
to 👀 In review
in Mod Manager (SMM) and CLI
budak7273
moved this from 👀 Ready for Ficsit Team review
to 🏗 In progress
in Rose Senior Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small UI change for readability