Skip to content

AMICANative(threads=...) does not change the binary's thread count #358

Description

@neuromechanist

Found during epic #324 Phase 17 (#355).

AMICANative(threads=...) sets OMP_NUM_THREADS, but the binary calls omp_set_num_threads(max_threads) from input.param (amica15.f90:95-100). So the binary always runs with max_threads, 10 by default. With threads=2 its stdout still reports "using 10 threads".

Expected: threads sets the binary's thread count, or the parameter is removed in favor of max_threads. The docs should say which one controls it.

benchmarks/reproduce_table1.py passes both threads and max_threads, so its runs used the requested count.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions