FIX: Backwards compatibility with <1.1 API#579
Open
oesteban wants to merge 1 commit intoscholarly-python-package:mainfrom
Open
FIX: Backwards compatibility with <1.1 API#579oesteban wants to merge 1 commit intoscholarly-python-package:mainfrom
oesteban wants to merge 1 commit intoscholarly-python-package:mainfrom
Conversation
cxhernandez
added a commit
to cxhernandez/cxhernandez.com
that referenced
this pull request
Jan 19, 2026
Based on scholarly PR #579 which fixes the FreeProxies compatibility issue, re-enable proxy support with a version constraint (>=1.7.12) to ensure the fix is included. This should resolve the 'Client.__init__() got an unexpected keyword argument proxies' error while maintaining proxy support for better reliability. Ref: scholarly-python-package/scholarly#579
cxhernandez
added a commit
to cxhernandez/cxhernandez.com
that referenced
this pull request
Jan 19, 2026
The proxy fix PR is still open and not merged, so the compatibility issue persists. Reverting to disabled proxy setup which works reliably. The scholarly package's session management is sufficient for now. Can re-enable proxy support once PR #579 is merged and released. Ref: scholarly-python-package/scholarly#579
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #578
Description
Describe your addition briefly to help the reviewers understand your contribution.
Checklist
developand notmain.If you don't have a premium proxy, some of the tests will be skipped.
The tests that are run should pass without raising
MaxTriesExceededExceptionor other exceptions.