Use qtpy Signal in DiscreteColorWidget for PySide6 compatibility#399
Open
fjorka wants to merge 1 commit into
Open
Use qtpy Signal in DiscreteColorWidget for PySide6 compatibility#399fjorka wants to merge 1 commit into
fjorka wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
import napari_spatialdatafails under PySide6:_scatterwidgets.pytakespyqtSignal(a PyQt-only name) from pyqtgraph's shim forDiscreteColorWidget.paletteChanged. Since__init__.pyimports_view→_scatterwidgets, the whole package is unimportable under PySide6, not just the scatter widget. These are the only PyQt-only names in the codebase, so this is the complete fix.Fix
Use qtpy's
Signal, already imported in this file and already used byScatterListWidget.attrChanged.Verification
Context
I introduced this in #270; it went unnoticed because the
allextra installsnapari[pyqt5].Same breakage as #397, this is a minimal internal fix.