Skip to content

Conversation

@keller-mark
Copy link
Contributor

Hi,
I wanted to clarify the logic for inferring the intrinsic coordinate system name here by adding an example.

Please let me know if this understanding of how the intrinsic coordinate systems are named is incorrect. Thanks!

@keller-mark keller-mark marked this pull request as ready for review July 30, 2025 22:20
@keller-mark keller-mark changed the title Add intrinsic coordinate system name example Design doc: Add intrinsic coordinate system name example Jul 30, 2025
@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.20%. Comparing base (7604a3d) to head (02e0877).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
+ Coverage   92.14%   92.20%   +0.06%     
==========================================
  Files          48       49       +1     
  Lines        7473     7560      +87     
==========================================
+ Hits         6886     6971      +85     
- Misses        587      589       +2     

see 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaMarconato
Copy link
Member

Thanks Mark! We actually don't give much important to the name of the intrinsic coordinate system in the code, and we don't expose this in-memory to the user, so I removed the sentence that you added—but I have added that each extrinsic coordinate system has a name (otherwise the reader may indeed wonder what is the name of the intrinsic coordinate system).

With the latest version of the NGFF spec, the concept of intrinsic coordinate system will change a bit. We will try to prioritize the adoption on the specs to remove all the confusion and inconsistencies around this concept.

@LucaMarconato LucaMarconato merged commit 30d29bb into scverse:main Jan 4, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants