Subset of fixes to AdvancedShardAwarenessIT#737
Merged
dkropachev merged 5 commits intoscylladb:scylla-4.xfrom Oct 6, 2025
Merged
Conversation
These patterns ensure that certain steps were taken, but their end result is already covered by pattern checking that reconnection completed with max total number of channels.
Makes Patterns of expected logs more specific so that they can match only logs relevant to the test cluster.
Not doing so can lead to concurrent modification exception, since the collection may change during the iteration. Those changes itself are not relevant at that point in time.
Replaces hardcoded sleeps with awaits in AdvancedShardAwarenessIT. Saves some time if the code completes faster. The new awaiting time limit is longer than previous sleeps but it won't be exhausted if everything works.
dkropachev
approved these changes
Oct 6, 2025
Moves it to IsolatedTests category for some extra safety
Author
|
I've forgot to make it isolated. Added a commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#676 without configuration changes. Only fixes in logic.
This is done in order to help investigate how does the test behave if the produced load is not altered and other issues
unrelated to the high load are fixed.
Note that some connection pool sizes were changed for example from 64 to 66. Those are not real changes since
64 was always under the hood rounded up to 66 to be divisible by the number of shards. Those adjustments do not
actually change the pool size in the test.