Implement KD Tree indexer #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4adex
force-pushed
the
kd_tree_refactor
branch
from
270fee6 to
fb0573d
Compare
Arshdeep54
requested changes
Jan 18, 2026
crates/index/src/kd_tree/index.rs
Outdated
| self.check_and_rebalance(&path); | ||
| } | ||
|
|
||
| // Rebuild helper methods |
Contributor
There was a problem hiding this comment.
Shift the helper methods to different file
crates/index/src/kd_tree/types.rs
Outdated
| pub left: Option<Box<KDTreeNode>>, | ||
| pub right: Option<Box<KDTreeNode>>, | ||
| pub is_deleted: bool, | ||
|
|
Contributor
There was a problem hiding this comment.
Can we add axis field in the node itself?
crates/index/src/kd_tree/types.rs
Outdated
| #[derive(Debug, Clone, PartialEq)] | ||
| pub struct Neighbor { | ||
| pub id: PointId, | ||
| pub distance: f32, |
Contributor
There was a problem hiding this comment.
Refer
I added this type for usage in binaryheap, see if it is of any use here.
Collaborator
Author
There was a problem hiding this comment.
Yes, used same type in Neighbor definition
Arshdeep54
reviewed
Jan 21, 2026
| pub const DELETE_REBUILD_RATIO: f32 = 0.25; | ||
|
|
||
| /// Checks if a node is unbalanced based on the balance threshold | ||
| pub fn is_unbalanced(node: &KDTreeNode) -> bool { |
Contributor
There was a problem hiding this comment.
We can have these helpers as impl for KDTreeNode{}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.