Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ ARG VARIANT="3"

FROM mcr.microsoft.com/vscode/devcontainers/ruby:${VARIANT}

ARG NODE_VERSION="20"
ARG NODE_VERSION="24"

# https://github.com/microsoft/vscode-dev-containers/blob/main/containers/go/.devcontainer/base.Dockerfile
ENV USERNAME=vscode
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"build": {
"dockerfile": "Dockerfile",
"args": {
"NODE_VERSION": "20",
"NODE_VERSION": "24",
"VARIANT": "3"
}
},
Expand Down
18 changes: 13 additions & 5 deletions .github/actions/setup-node/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ inputs:
node_version:
description: The Node.js version.
required: false
default: '20'
default: '24'
registry_url:
description: The Node.js package registry URL.
required: false
Expand All @@ -20,19 +20,27 @@ runs:
using: composite
steps:
- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v7
if: inputs.install_dependencies == 'true'
with:
cache: npm
node-version: ${{ inputs.node_version }}
registry-url: ${{ inputs.registry_url }}
- name: Setup Node.js without cache
uses: actions/setup-node@v4
uses: actions/setup-node@v7
if: inputs.install_dependencies == 'false'
with:
node-version: ${{ inputs.node_version }}
registry-url: ${{ inputs.registry_url }}
- name: Install dependencies
if: inputs.install_dependencies == 'true'
shell: bash
run: npm ci
run: npm ci --ignore-scripts
- name: Rebuild Node.js modules
shell: bash
run: npm rebuild
- name: Run postinstall script
shell: bash
run: npm run postinstall --if-present
- name: Run prepare script
shell: bash
run: npm run prepare --if-present
4 changes: 2 additions & 2 deletions .github/workflows/_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ jobs:
timeout-minutes: 30
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7
- name: Setup
uses: ./.github/actions/setup
with:
ruby_version: ${{ inputs.ruby_version }}
- name: Build
run: bundle exec rake build
- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: build-${{ github.sha }}
if-no-files-found: error
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ jobs:
timeout-minutes: 30
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7
- name: Setup
uses: ./.github/actions/setup
with:
install_dependencies: 'false'
gem_credentials: ':${{ inputs.registry_key }}: ${{ secrets.registry_credentials }}'
- name: Download artifact
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8
with:
name: ${{ inputs.artifact_name }}
path: pkg/
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
os_name: Linux
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7
- name: Setup
uses: ./.github/actions/setup
with:
Expand All @@ -50,7 +50,7 @@ jobs:
- '3.3'
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7
- name: Setup
uses: ./.github/actions/setup
with:
Expand Down Expand Up @@ -83,12 +83,12 @@ jobs:
with:
ruby-version: ${{ matrix.ruby }}
- name: Download artifact
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8
with:
name: ${{ needs.build.outputs.artifact_name }}
path: .
- name: Find gems
uses: tj-actions/glob@v21
uses: tj-actions/glob@v22
id: gems
with:
files: '*.gem'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ jobs:
timeout-minutes: 30
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
ref: ${{ github.head_ref }}
token: ${{ secrets.GH_TOKEN }}
- name: Import GPG key
uses: crazy-max/ghaction-import-gpg@v6
uses: crazy-max/ghaction-import-gpg@v7
with:
git_user_signingkey: true
git_commit_gpgsign: true
Expand All @@ -36,7 +36,7 @@ jobs:
- name: Format with Prettier
run: npm run format
- name: Commit
uses: stefanzweifel/git-auto-commit-action@v5
uses: stefanzweifel/git-auto-commit-action@v7
if: always()
with:
commit_message: 'ci: Format code'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/generate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ jobs:
timeout-minutes: 30
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
ref: ${{ github.head_ref }}
token: ${{ secrets.GH_TOKEN }}
- name: Import GPG key
uses: crazy-max/ghaction-import-gpg@v6
uses: crazy-max/ghaction-import-gpg@v7
with:
git_user_signingkey: true
git_commit_gpgsign: true
Expand All @@ -42,7 +42,7 @@ jobs:
- name: Generate code
run: npm run generate
- name: Commit
uses: stefanzweifel/git-auto-commit-action@v5
uses: stefanzweifel/git-auto-commit-action@v7
with:
commit_message: 'ci: Generate code'
commit_user_name: ${{ secrets.GIT_USER_NAME }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ jobs:
needs: build
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
fetch-depth: 0
- name: Download artifact
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8
with:
name: ${{ needs.build.outputs.artifact_name }}
path: pkg/
Expand All @@ -36,7 +36,7 @@ jobs:
npx standard-changelog@^5.0.0 --release-count 2 --infile $outfile.tmp --outfile $outfile.tmp
sed '1,3d' $outfile.tmp > $outfile
- name: Create GitHub release
uses: softprops/action-gh-release@v2
uses: softprops/action-gh-release@v3
with:
token: ${{ secrets.GH_TOKEN }}
fail_on_unmatched_files: true
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/semantic-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ jobs:
new_release_version: ${{ steps.release.outputs.new_release_version }}
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
fetch-depth: 0
- name: Semantic release
id: release
uses: cycjimmy/semantic-release-action@v4
uses: cycjimmy/semantic-release-action@v6
with:
dry_run: true
release:
Expand All @@ -38,7 +38,7 @@ jobs:
if: needs.semantic.outputs.new_release_published == 'true' && needs.semantic.outputs.new_release_version != '1.0.0'
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
fetch-depth: 1
- name: Release version ${{ needs.semantic.outputs.new_release_version }} on ${{ github.ref_name }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ jobs:
timeout-minutes: 30
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v7
with:
token: ${{ secrets.GH_TOKEN }}
- name: Import GPG key
uses: crazy-max/ghaction-import-gpg@v6
uses: crazy-max/ghaction-import-gpg@v7
with:
git_user_signingkey: true
git_commit_gpgsign: true
Expand Down
1 change: 0 additions & 1 deletion .nvmrc

This file was deleted.

2 changes: 1 addition & 1 deletion codegen/lib/layouts/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const getMethodLayoutContext = (
const sortedParameters = sortClientMethodParameters(parameters)

const signatureParams = sortedParameters
.map((p) => `${p.name}${p.required ?? false ? ':' : ': nil'}`)
.map((p) => `${p.name}${(p.required ?? false) ? ':' : ': nil'}`)
.concat(canPollActionAttempt ? ['wait_for_action_attempt: nil'] : [])
.join(', ')

Expand Down
4 changes: 2 additions & 2 deletions codegen/lib/ruby-client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@ export const sortClientMethodParameters = (
): ClientMethodParameter[] =>
[...parameters].sort(
(a, b) =>
(a.position ?? (a.required ?? false ? 1000 : 9999)) -
(b.position ?? (b.required ?? false ? 1000 : 9999)),
(a.position ?? ((a.required ?? false) ? 1000 : 9999)) -
(b.position ?? ((b.required ?? false) ? 1000 : 9999)),
)
Loading
Loading