Open
Conversation
Member
|
Leibniz notation is going to be hard to handle within the parser. I would suggest parsing And then performing a transform on the AST that converts fractions that look like |
k4b7
reviewed
Jun 17, 2017
| suite('nthRoot', [ | ||
| 'nthRoot(x)', | ||
| 'nthRoot(x, 3)', | ||
| 'nthRoot(8, 3)', |
k4b7
reviewed
Jun 17, 2017
| if (args.length > 1) { | ||
| return build.applyNode('add', args.map(term => | ||
| term.addParens ? build.parensNode(term) : term)) | ||
| term.addParens ? build.parensNode(term) : term)) |
Member
There was a problem hiding this comment.
I don't think this formatting change adds anything.
k4b7
reviewed
Jun 17, 2017
| return factors.length > 1 | ||
| ? build.applyNode('mul', factors, {implicit: true}) | ||
| : factors[0]; | ||
| : factors[0]; |
Contributor
Author
There was a problem hiding this comment.
Sorry! It's an issue with my text edit and the auto configs I have. Will fix
k4b7
reviewed
Jun 17, 2017
|
|
||
| // Lagrange notation | ||
| // e.g. f', f'', f'(x) | ||
| if (node.name === 'f' && matches(this.currentToken(), `'`)) { |
Member
There was a problem hiding this comment.
This is pretty restrictive. We should be able to parse the derivative of any function (or expression). This is so we can handle things like (af + bg)'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on derivative parsing.