fix: ignore issue references inside HTML comments#144
Open
LuisUrrutia wants to merge 1 commit intosemantic-release:masterfrom
Open
fix: ignore issue references inside HTML comments#144LuisUrrutia wants to merge 1 commit intosemantic-release:masterfrom
LuisUrrutia wants to merge 1 commit intosemantic-release:masterfrom
Conversation
babblebey
approved these changes
Dec 17, 2025
Member
babblebey
left a comment
babblebey
left a comment
There was a problem hiding this comment.
This Looks great, thanks @LuisUrrutia
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes semantic-release/github#143
Closes #149
<!-- -->)Solution
Added
HTML_COMMENT_REGEXPto strip HTML comments from text before parsing, consistent with existing handling for:```)`)<code>tagsComments are replaced with a space (not removed entirely) to preserve word boundaries between adjacent text.
Changes
index.js: AddedHTML_COMMENT_REGEXPand filtering stepindex.js: RenamednoCodeBlock→filteredTextfor claritytest/index.test.js: Added tests for HTML comment exclusion