Adjust kernel extension code setting up StructInitInfo#1193
Merged
Conversation
Collaborator
|
Seemed to pass the CI here too, so hopefully safe to merge this? Took the liberty of reformatting, thanks @fingolfin |
Currently GAP's `StructInitInfo` struct type contains several obsolete fields which cannot be removed or replaced because of kernel extensions relying on the specific layout of this struct. This patch removes this reliance for this package and thus gets us one step closer to eventually allowing such a refactoring of the struct in the GAP kernel. The technique employed here used to work only in C, but at least locally it works for me in this C++ code base, too. Not sure if that is due to enhancements in newer C++ standards, or a non-portable compiler extension, or something else...
fingolfin
force-pushed
the
mh/StructInitInfo
branch
from
d2471bf to
61400cf
Compare
Contributor
Author
|
Happy about formatting changes, do as you like! It still failed, though. I've run After installing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently GAP's
StructInitInfostruct type contains severalobsolete fields which cannot be removed or replaced because of
kernel extensions relying on the specific layout of this struct.
This patch removes this reliance for this package and thus gets
us one step closer to eventually allowing such a refactoring of
the struct in the GAP kernel.
The technique employed here used to work only in C, but at least
locally it works for me in this C++ code base, too. Not sure if
that is due to enhancements in newer C++ standards, or a non-portable
compiler extension, or something else...