Fix #638 and #639: treat single column unique indexes as primary key#640
Open
hhowe29 wants to merge 2 commits intosequelize:masterfrom
Open
Fix #638 and #639: treat single column unique indexes as primary key#640hhowe29 wants to merge 2 commits intosequelize:masterfrom
hhowe29 wants to merge 2 commits intosequelize:masterfrom
Conversation
…t single column unique indexes as a primary key if no other primary key was found. Fixes sequelize#638 and implement sequelize#639.
Member
|
I don't think we should do #639. I understand that you have legacy tables but unique columns are not primary keys and we should not mark them as such in their corresponding models |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #638 and implement #639.