[Fix #1276] Ignoring isNull for JacksonModel serialization#1277
Merged
fjtirado merged 1 commit intoserverlessworkflow:mainfrom Mar 30, 2026
Merged
[Fix #1276] Ignoring isNull for JacksonModel serialization#1277fjtirado merged 1 commit intoserverlessworkflow:mainfrom
fjtirado merged 1 commit intoserverlessworkflow:mainfrom
Conversation
fjtirado
changed the title
…ization Signed-off-by: fjtirado <ftirados@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes #1276 by preventing Jackson from treating WorkflowModel.isNull() as a serializable bean property when working with the Jackson-backed model implementation.
Changes:
- Add
@JsonIgnoretoJacksonModel.isNull()to keep it out of Jackson serialization output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
51
to
54
| @Override | ||
| @JsonIgnore | ||
| public boolean isNull() { | ||
| return node.isNull(); |
There was a problem hiding this comment.
Consider adding a regression test that serializing a JacksonModel with Jackson (e.g., ObjectMapper.writeValueAsString on a JacksonModel or WorkflowModel reference) does not emit a "null" field derived from isNull(). This change is intended to prevent Jackson from treating isNull as a bean property, but it’s currently untested in this module despite existing JacksonModel tests.
mcruzdev
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1276