Fix DeepFM dense-only loading, DNN save tracking, and FNN logits#555
Merged
Conversation
This was referenced Apr 26, 2026
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | -5 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #555 +/- ##
==========================================
+ Coverage 78.23% 78.31% +0.08%
==========================================
Files 61 61
Lines 3331 3325 -6
==========================================
- Hits 2606 2604 -2
+ Misses 725 721 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the first batch of triaged open issues:
It also updates
Linear.add_weightcalls to passname=explicitly, which keeps the touched DeepFM dense-only path compatible with modern Keras.Validation
python -m pytest tests/models/DeepFM_test.py::test_DeepFM_dense_only_model_io tests/layers/core_test.py::test_DNN_output_activation tests/models/FNN_test.py::test_FNN_does_not_add_wide_linear_logit -qpython -m pytest tests/feature_test.py::test_create_embedding_matrix_reuses_same_embedding_name tests/feature_test.py::test_create_embedding_matrix_rejects_inconsistent_shared_embedding -qHash(4, mask_zero=True)range check