Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #15021
Contributor checklist
Fixes #1234syntaxDescription
What this fixes
An incoming edit is stored with the original message's
date_received, so it never advances the conversation's mark-read watermark and is never marked read while you're looking at it, the sender keeps seeing the edit as unread until they send another message. This marks the new revision read inEditMessageProcessorright after a successful insert, (only when the edit's thread is the one on screen).Testing
Added
EditMessageProcessorTest_markRead(instrumented, 3 cases), and confirmed it catches the bug: with the fix reverted the visible-thread case fails, with it applied all three pass. Run on a Pixel 9.Manually tested the bug on
mainand on this branch. Before the fix, the read message never appeared as read, until a later message was sent (or the receiver exited to the list screen and reopened the conversation screen). After the fix, the message was marked as read when expected.