Skip to content

Fix new problem with LT-11746: Make Preview aware of publication#858

Open
jtmaxwell3 wants to merge 1 commit intomainfrom
LT-11746b
Open

Fix new problem with LT-11746: Make Preview aware of publication#858
jtmaxwell3 wants to merge 1 commit intomainfrom
LT-11746b

Conversation

@jtmaxwell3
Copy link
Copy Markdown
Collaborator

@jtmaxwell3 jtmaxwell3 commented Apr 30, 2026

This fixes a new problem with https://jira.sil.org/browse/LT-11746: Lexical relations shouldn't be shown if they are not in the current publication. The solution was to pass in a DictionaryPublicationDecorator like the one in XhtmlDocView.cs.


This change is Reviewable

@github-actions
Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   7m 3s ⏱️ +35s
4 103 tests ±0  4 032 ✅ ±0  71 💤 ±0  0 ❌ ±0 
4 112 runs  ±0  4 041 ✅ ±0  71 💤 ±0  0 ❌ ±0 

Results for commit ff35b4a. ± Comparison against base commit 5334190.

@jasonleenaylor
Copy link
Copy Markdown
Contributor

Src/xWorks/XhtmlRecordDocView.cs line 170 at r1 (raw file):

				var configuration = new DictionaryConfigurationModel(configurationFile, Cache);
				PublicationDecorator.Refresh();
				var xhtmlPath = LcmXhtmlGenerator.SavePreviewHtmlWithStyles(new [] { cmo.Hvo }, Clerk, PublicationDecorator, configuration, m_propertyTable);

Did you check and see if there are any visual changes after this beyond the current bug fix?
We explicitly passed null here before and I think we have some code that expected that for the single entry preview styling. That was probably overloading the parameter, so the fix isn't to undo this but to make that single entry view explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants