test: add FdoUi delete regression#868
Closed
johnml1135 wants to merge 2 commits intomainfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR separates non-render follow-up work by adding a focused FdoUi regression test for the delete pub/sub path, and hardening several Generic native macros to use two-step token-pasting for line-number-based local-variable names.
Changes:
- Added an FdoUi regression test asserting
CmObjectUi.DeleteUnderlyingObject()publishesEventConstants.DeleteRecordfor the current object. - Updated
MeasureDuration,LockThis/LockObj, andGenLockThis/GenLockObjmacros to use two-step token pasting with__LINE__.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Src/Generic/UtilTime.h | Adds two-step concat helper macros used by MeasureDuration to correctly paste __LINE__. |
| Src/Generic/UtilCom.h | Adds two-step concat helper macros used by LockThis/LockObj to correctly paste __LINE__. |
| Src/Generic/GenSmartPtr.h | Adds two-step concat helper macros used by GenLockThis/GenLockObj to correctly paste __LINE__. |
| Src/FdoUi/FdoUiTests/FdoUiTests.cs | Adds a regression test ensuring DeleteUnderlyingObject() publishes DeleteRecord. |
Contributor
Author
|
This has become almost a nothing - I am closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the remaining focused FdoUi regression test extracted from #724:
CmObjectUi.DeleteUnderlyingObject()publishesEventConstants.DeleteRecordfor the current objectWhy Separate
Validation
get_errorsonSrc/FdoUi/FdoUiTests/FdoUiTests.cs: no errors../test.ps1 -SkipNative -TestProject "FdoUiTests" -TestFilter "FullyQualifiedName~DeleteUnderlyingObject_PublishesDeleteRecordForCurrentObject"; local build is currently blocked before the managed test runs by an unrelated native Views build failure whereVwRootBoxis abstract becauseIVwRootBox::get_NeedsReconstruct(ComBool *)is not implemented.Related PR
This change is