Skip to content

test: add FdoUi delete regression#868

Closed
johnml1135 wants to merge 2 commits intomainfrom
001-render-fdoui-generic
Closed

test: add FdoUi delete regression#868
johnml1135 wants to merge 2 commits intomainfrom
001-render-fdoui-generic

Conversation

@johnml1135
Copy link
Copy Markdown
Contributor

@johnml1135 johnml1135 commented May 6, 2026

Summary

This PR contains the remaining focused FdoUi regression test extracted from #724:

  • proves CmObjectUi.DeleteUnderlyingObject() publishes EventConstants.DeleteRecord for the current object

Why Separate

Validation

  • get_errors on Src/FdoUi/FdoUiTests/FdoUiTests.cs: no errors.
  • Attempted ./test.ps1 -SkipNative -TestProject "FdoUiTests" -TestFilter "FullyQualifiedName~DeleteUnderlyingObject_PublishesDeleteRecordForCurrentObject"; local build is currently blocked before the managed test runs by an unrelated native Views build failure where VwRootBox is abstract because IVwRootBox::get_NeedsReconstruct(ComBool *) is not implemented.

Related PR


This change is Reviewable

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR separates non-render follow-up work by adding a focused FdoUi regression test for the delete pub/sub path, and hardening several Generic native macros to use two-step token-pasting for line-number-based local-variable names.

Changes:

  • Added an FdoUi regression test asserting CmObjectUi.DeleteUnderlyingObject() publishes EventConstants.DeleteRecord for the current object.
  • Updated MeasureDuration, LockThis/LockObj, and GenLockThis/GenLockObj macros to use two-step token pasting with __LINE__.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
Src/Generic/UtilTime.h Adds two-step concat helper macros used by MeasureDuration to correctly paste __LINE__.
Src/Generic/UtilCom.h Adds two-step concat helper macros used by LockThis/LockObj to correctly paste __LINE__.
Src/Generic/GenSmartPtr.h Adds two-step concat helper macros used by GenLockThis/GenLockObj to correctly paste __LINE__.
Src/FdoUi/FdoUiTests/FdoUiTests.cs Adds a regression test ensuring DeleteUnderlyingObject() publishes DeleteRecord.

Comment thread Src/Generic/UtilTime.h Outdated
Comment thread Src/Generic/UtilCom.h Outdated
Comment thread Src/Generic/GenSmartPtr.h Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   6m 23s ⏱️ -2s
4 103 tests +1  4 032 ✅ +1  71 💤 ±0  0 ❌ ±0 
4 112 runs  +1  4 041 ✅ +1  71 💤 ±0  0 ❌ ±0 

Results for commit b63a1f9. ± Comparison against base commit db39df6.

♻️ This comment has been updated with latest results.

@johnml1135 johnml1135 changed the title test: split FdoUi delete regression and Generic macro fixes test: add FdoUi delete regression May 6, 2026
@johnml1135
Copy link
Copy Markdown
Contributor Author

This has become almost a nothing - I am closing it.

@johnml1135 johnml1135 closed this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants