Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Jan 12, 2026

Fixes #243


This change is Reviewable

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @pmachapman).


pyproject.toml line 87 at r1 (raw file):

jupyter = "^1.0.0"
pandas = "^2.0.3"
pyright = { extras = ["nodejs"], version = "^1.1.400" }

Why did we need the nodejs extra previously? 🤔

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.74%. Comparing base (9868016) to head (cd32175).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files         352      352           
  Lines       22337    22337           
=======================================
  Hits        20270    20270           
  Misses       2067     2067           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator Author

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmachapman made 1 comment.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93).


pyproject.toml line 87 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

Why did we need the nodejs extra previously? 🤔

Turns out I used the wrong poetry command to update pyright. I was meant to include [nodejs] at the end, as pyright requires nodejs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Python version support (>= 3.10, < 3.14)

4 participants