Skip to content

fix: add retry logic to NVMe controller attachment in storage_node_ops.py #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hamdy-khader wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: add retry logic to NVMe controller attachment in storage_node_ops.py #1101

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e53bbb7
fix: add retry logic to NVMe controller attachment in storage_node_op…
Hamdy-khader Jun 15, 2026
315c8f7
add break
Hamdy-khader Jun 15, 2026
80a5c88
fix: add break condition to NVMe controller list retry logic in stora…
Hamdy-khader Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions simplyblock_core/storage_node_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,11 +931,18 @@ def _create_device_partitions(rpc_client, nvme, snode, num_partitions_per_dev, j
if not rpc_client.bdev_nvme_controller_list(nvme.nvme_controller):
break
time.sleep(1)
try:
rpc_client.bdev_nvme_controller_attach(nvme.nvme_controller, nvme.pcie_address)
except RPCException as e:
logger.error('Failed to create device partitions: ' + str(e))
return False

for i in range(10):
try:
rpc_client.bdev_nvme_controller_attach(nvme.nvme_controller, nvme.pcie_address)
break
except RPCException:
logger.error('Failed to create device partitions, retrying...')
time.sleep(1)
if rpc_client.bdev_nvme_controller_list(nvme.nvme_controller):
break
time.sleep(1)

time.sleep(1)
rpc_client.bdev_examine(nvme.nvme_bdev)
time.sleep(1)
Expand Down
Loading