Target worker node verification after storage node migration#304
Open
noctarius wants to merge 2 commits into
Open
Target worker node verification after storage node migration#304noctarius wants to merge 2 commits into
noctarius wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a post-restart verification step for StorageNodeSet “migration” restarts to ensure the storage node actually comes online on the intended Kubernetes worker node, emitting a warning event (and failing the action) if it comes up on a different worker.
Changes:
- Refactors
waitForActionCompletionto take the fullStorageNodeSetCR and, on successful completion, perform worker assignment verification for targeted restarts. - Introduces
verifyWorkerAssignmentthat compares the storage-node API’smgmt_ipto the target worker’sNodeInternalIP, emitting aWorkerAssignmentMismatchwarning event on mismatch. - Adds unit tests covering the new verification behavior and updates existing tests for the new
waitForActionCompletionsignature.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/controller/simplyblockstoragenodeset_controller.go | Adds worker assignment verification after restart completion and changes waitForActionCompletion signature to pass the CR. |
| internal/controller/simplyblockstoragenodeset_controller_unit_test.go | Updates tests for the refactor and adds targeted unit tests for worker assignment verification + event emission. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2dc0582 to
c7f8bd3
Compare
… This post-startup verification is used to create error events in case the storage node was started on an unexpected (e.g., old host after a node migration) worker node.
c7f8bd3 to
d6faf2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added worker node verification after the storage node becomes online. This post-startup verification is used to create error events in case the storage node was started on an unexpected (e.g., old host after a node migration) worker node.