Skip to content

Target worker node verification after storage node migration#304

Open
noctarius wants to merge 2 commits into
mainfrom
fix-storagenode-migration
Open

Target worker node verification after storage node migration#304
noctarius wants to merge 2 commits into
mainfrom
fix-storagenode-migration

Conversation

@noctarius

Copy link
Copy Markdown
Collaborator

Added worker node verification after the storage node becomes online. This post-startup verification is used to create error events in case the storage node was started on an unexpected (e.g., old host after a node migration) worker node.

@noctarius noctarius self-assigned this Jul 7, 2026
Copilot AI review requested due to automatic review settings July 7, 2026 10:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a post-restart verification step for StorageNodeSet “migration” restarts to ensure the storage node actually comes online on the intended Kubernetes worker node, emitting a warning event (and failing the action) if it comes up on a different worker.

Changes:

  • Refactors waitForActionCompletion to take the full StorageNodeSet CR and, on successful completion, perform worker assignment verification for targeted restarts.
  • Introduces verifyWorkerAssignment that compares the storage-node API’s mgmt_ip to the target worker’s NodeInternalIP, emitting a WorkerAssignmentMismatch warning event on mismatch.
  • Adds unit tests covering the new verification behavior and updates existing tests for the new waitForActionCompletion signature.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
internal/controller/simplyblockstoragenodeset_controller.go Adds worker assignment verification after restart completion and changes waitForActionCompletion signature to pass the CR.
internal/controller/simplyblockstoragenodeset_controller_unit_test.go Updates tests for the refactor and adds targeted unit tests for worker assignment verification + event emission.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/controller/simplyblockstoragenodeset_controller.go
@noctarius noctarius force-pushed the fix-storagenode-migration branch from 2dc0582 to c7f8bd3 Compare July 10, 2026 12:58
… This post-startup verification is used to create error events in case the storage node was started on an unexpected (e.g., old host after a node migration) worker node.
@noctarius noctarius force-pushed the fix-storagenode-migration branch from c7f8bd3 to d6faf2f Compare July 10, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants