Skip to content

feat(claude): add you-might-not-need-an-effect slash command#4018

Merged
waleedlatif1 merged 3 commits intostagingfrom
waleedlatif1/add-effect-skill
Apr 7, 2026
Merged

feat(claude): add you-might-not-need-an-effect slash command#4018
waleedlatif1 merged 3 commits intostagingfrom
waleedlatif1/add-effect-skill

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • Add /you-might-not-need-an-effect slash command to analyze and fix useEffect anti-patterns

Type of Change

  • New feature

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 7, 2026

PR Summary

Low Risk
Changes are limited to agent/command documentation and repo rules with no impact on runtime application code paths. Risk is mainly that updated guidance could influence future implementations rather than introduce direct regressions.

Overview
Adds a new /you-might-not-need-an-effect command/skill for analyzing and optionally fixing React useEffect anti-patterns.

Updates internal integration playbooks: block creation guidance now requires integrationType and tags, connector guidance adopts a contentDeferred + metadata-based contentHash pattern, and a new add-hosted-key guide documents how to add hosted API key support (BYOK registration, metering, and UI hiding).

Expands repo-wide developer rules with a landing-page SEO/GEO checklist, stricter React Query key/cancellation/invalidation patterns, and additional apps/sim/AGENTS.md architecture/utilities conventions.

Reviewed by Cursor Bugbot for commit 338d155. Configure here.

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Apr 7, 2026

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Apr 7, 2026 6:54pm

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 7, 2026

Greptile Summary

This PR adds a /you-might-not-need-an-effect slash command that analyzes and optionally fixes useEffect anti-patterns based on the React docs. The command is registered consistently across all three config systems (.claude/commands, .cursor/commands, .agents/skills) and correctly forwards user arguments via $ARGUMENTS.

  • New .claude/commands/you-might-not-need-an-effect.md with YAML frontmatter (description, argument-hint: [scope] [fix=true|false]) and $ARGUMENTS forwarding — addressing the previous reviewer comment
  • New .cursor/commands/you-might-not-need-an-effect.md without frontmatter, consistent with the existing Cursor command convention in this repo (e.g., add-integration.md also has no frontmatter)
  • New .agents/skills/you-might-not-need-an-effect/SKILL.md with name/description frontmatter and $ARGUMENTS placeholder
  • New .claude/rules/landing-seo-geo.md scoped to apps/sim/app/(home)/**/*.tsx with SEO heading-hierarchy and GEO answer-first pattern guidelines
  • Updated .claude/rules/sim-queries.md with hierarchical key factory pattern, onSettled reconciliation guidance, and useCallback dependency rules
  • Updated .agents/skills/add-block/SKILL.md requiring integrationType and tags fields in block configs
  • New .claude/commands/council.md for spawning exploration task agents

Confidence Score: 5/5

Safe to merge — no production code changes, all modifications are tooling and documentation files.

This PR touches only agent skill definitions, slash command files, and rule documents. No application code, no migrations, no API changes. The previous P1 concern about missing $ARGUMENTS was resolved in this revision. All three config systems register the command consistently.

No files require special attention.

Important Files Changed

Filename Overview
.claude/commands/you-might-not-need-an-effect.md New slash command with correct YAML frontmatter, $ARGUMENTS forwarding, and three clear steps
.cursor/commands/you-might-not-need-an-effect.md New Cursor command without frontmatter — consistent with other .cursor/commands/ files in the repo
.agents/skills/you-might-not-need-an-effect/SKILL.md New agent skill with correct name/description frontmatter and $ARGUMENTS placeholder
.claude/rules/landing-seo-geo.md New SEO/GEO rule scoped to landing page templates
.claude/rules/sim-queries.md Updated React Query patterns with hierarchical key factory and improved mutation guidelines
.agents/skills/add-block/SKILL.md Updated to require integrationType and tags in block configs
.claude/commands/council.md New council command for spawning task agents

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User types /you-might-not-need-an-effect] --> B{Arguments provided?}
    B -- Yes --> C[Parse scope and fix=true/false]
    B -- No --> D[Defaults: scope=current changes, fix=true]
    C --> E[Read react.dev/learn/you-might-not-need-an-effect]
    D --> E
    E --> F[Analyze scope for useEffect anti-patterns]
    F --> G{fix=true?}
    G -- Yes --> H[Apply fixes to codebase]
    G -- No --> I[Propose fixes without applying]
Loading

Reviews (2): Last reviewed commit: "fix(config): add frontmatter and $ARGUME..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 force-pushed the waleedlatif1/add-effect-skill branch from f8ee325 to e39c239 Compare April 7, 2026 18:50
@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@cursor review

@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@greptile

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 338d155. Configure here.

@waleedlatif1 waleedlatif1 merged commit 8372332 into staging Apr 7, 2026
12 checks passed
@waleedlatif1 waleedlatif1 deleted the waleedlatif1/add-effect-skill branch April 7, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant