feat(admin): add password user creation - #6267
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview A new Add user control opens Vitest covers modal validation, success paths, unverified flow (no platform-role UI), and Better Auth error handling, plus Reviewed by Cursor Bugbot for commit 1e2bfb2. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR adds an admin flow for creating password-based Better Auth users and displaying the resulting account through the existing user search.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/settings/components/admin/add-user-modal.tsx | Adds the validated, guarded credential-user creation form and mutation lifecycle handling. |
| apps/sim/hooks/queries/admin-users.ts | Adds normalized Better Auth credential-user creation and invalidates user-list queries after completion. |
| apps/sim/app/workspace/[workspaceId]/settings/components/admin/admin.tsx | Integrates the creation modal and searches for the newly created account on success. |
| packages/emcn/src/components/chip-modal/chip-modal.tsx | Adds an optional disabled state to the modal header close button. |
| apps/sim/app/workspace/[workspaceId]/settings/components/admin/add-user-modal.test.tsx | Covers validation, normalization, success, duplicate submission, verification status, and displayed errors. |
| apps/sim/hooks/queries/admin-users.test.ts | Covers the Better Auth request shape, resolved API errors, and missing-user responses. |
Sequence Diagram
sequenceDiagram
participant Admin
participant Modal as AddUserModal
participant Mutation as useAddUser
participant Auth as Better Auth
participant Query as Admin Users Query
Admin->>Modal: Enter name, email, password, verification status
Modal->>Mutation: Submit normalized AddUserInput
Mutation->>Auth: "admin.createUser(role=user)"
Auth-->>Mutation: Created user or error
alt Creation succeeds
Mutation-->>Modal: AdminUser
Modal-->>Admin: onCreated(user)
Admin->>Query: Search for created email
Mutation->>Query: Invalidate user-list queries
else Creation fails
Mutation-->>Modal: Display creation error
end
Reviews (3): Last reviewed commit: "fix(admin): reflect immediate submission..." | Re-trigger Greptile
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 44dfe92. Configure here.
Summary
userrole while preserving Better Auth user and account hooksType of Change
Testing
Checklist