Skip to content

feat(workflows): generate short machine-nature names - #6906

Open
j15z wants to merge 4 commits into
stagingfrom
feat/new-workflow-names
Open

feat(workflows): generate short machine-nature names#6906
j15z wants to merge 4 commits into
stagingfrom
feat/new-workflow-names

Conversation

@j15z

@j15z j15z commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • replace space-themed workflow names with short machine-nature pairs
  • weight names toward seven letters, followed by six, with 5,418 curated combinations using familiar, neutral words
  • automatically deduplicate generated names within each workflow folder
  • depend on the stable .mutate function so folder workflow creation callbacks are not recreated when mutation state changes
  • add coverage for weighting, uniqueness, formatting, excluded vocabulary, and deduplication

Type of Change

  • Feature

Testing

  • bun run test -- stores/workflows/registry/utils.test.ts lib/workflows/utils.test.ts lib/workflows/orchestration/workflow-lifecycle.test.ts app/workspace/[workspaceId]/w/components/sidebar/hooks/use-workflow-operations.test.tsx
  • bun run lint
  • bun run check:audits
  • bun run apps/sim/scripts/check-block-registry.ts origin/staging

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 21, 2026 1:21am

Request Review

@cursor

cursor Bot commented Aug 20, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Cosmetic naming and create-path wiring only; uses existing server-side name uniqueness rather than changing auth or persistence semantics.

Overview
New workflows now get short lowercase names like bolt-ivy instead of long space-themed pairs. Length is weighted toward seven letters (then six, then longer), from a curated machine/nature word list.

Sidebar create (root and in-folder) now passes deduplicate: true so collisions become name (2) instead of failing uniqueness. Tests cover weighting, word lists, and the create/dedup path.

Reviewed by Cursor Bugbot for commit 492c4a3. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Replaces the space-themed workflow-name generator with short lowercase machine-nature pairs.

  • Precomputes 7,050 candidates grouped by combined word length.
  • Weights selection toward seven-letter pairs.
  • Adds tests for weighting, formatting, word lengths, and candidate coverage.

Confidence Score: 4/5

The workflow-name collision behavior should be addressed before merging because an automatically generated duplicate currently prevents workflow creation.

The new generator selects once from a substantially smaller, non-uniform namespace, while creation callers neither retry nor request deduplication, so a collision is returned to the user as a conflict.

Files Needing Attention: apps/sim/stores/workflows/registry/utils.ts

Important Files Changed

Filename Overview
apps/sim/stores/workflows/registry/utils.ts Introduces the weighted machine-nature generator, but its reduced namespace materially increases creation failures from same-folder name collisions.
apps/sim/stores/workflows/registry/utils.test.ts Thoroughly verifies candidate formatting, length buckets, weighting, and all 7,050 combinations.

Reviews (1): Last reviewed commit: "feat(workflows): generate short machine-..." | Re-trigger Greptile

Comment on lines +219 to +220
const length = randomItem(PREFERRED_NAME_LENGTHS)
return randomItem(WORKFLOW_NAMES_BY_LENGTH[length])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Generated-name collisions block creation

When a folder already contains the selected machine-nature name, the generator returns that duplicate without retrying or suffixing it, causing workflow creation to return HTTP 409. The new length-weighted namespace contains only 7,050 names, materially increasing this failure rate over the previous larger Cartesian product.

@j15z j15z changed the title feat(workflows): generate short machine-nature names feat(workflows): short machine-nature default names for new workflows Aug 20, 2026
@j15z
j15z force-pushed the feat/new-workflow-names branch from 717846f to bea1ccc Compare August 20, 2026 23:55
@j15z j15z changed the title feat(workflows): short machine-nature default names for new workflows feat(workflows): generate short machine-nature names Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant