JAIPilot campaign evaluation: Spring Boot #51398 - #1
Open
skrcode wants to merge 1 commit into
Open
Conversation
RequireNewOrMatchingContentFileHandler reads the already generated file through content.getInputStream().readAllBytes(). InputStream.readAllBytes does not close the stream, and the stream is never assigned, so it cannot be closed at all. During AOT processing the content is a FileSystemResource, so each comparison leaks a file handle. FileSystemGeneratedFiles already uses try-with-resources when it consumes an InputStreamSource. Read the existing content inside a try-with-resources block. See spring-projectsgh-51385 Signed-off-by: dlwldn30 <dlwldn30@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact cloud-only evaluation mirror of spring-projects#51398
Exact upstream head: 915e477
JAIPilot must return at most one small, behavior-preserving, independently provable companion draft or leave this PR unchanged. No repository build is being run on a developer laptop.