Implement ping for smux sessions#359
Merged
0pcom merged 1 commit intoskycoin:developfrom Mar 30, 2026
Merged
Conversation
smux (unlike yamux) has no built-in ping. Implement it using a lightweight stream-level ping protocol: Client side (SessionCommon.Ping): - Opens a temporary smux stream - Writes a 2-byte zero marker [0x00, 0x00] (ping) - Reads 2-byte echo, measures RTT - Closes stream (5s deadline) Server side (serveStream): - Reads first 2 bytes of each new stream - If [0x00, 0x00]: echoes the marker back and closes (ping response) - Otherwise: passes the bytes through to readRequest via MultiReader The [0x00, 0x00] marker is safe because it represents a zero-length object, which cannot occur in normal session traffic (valid SignedObjects always have length > 0). Yamux sessions continue to use the built-in yamux.Ping().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smux (unlike yamux) has no built-in ping. Implement it using a lightweight stream-level ping protocol:
Client side (SessionCommon.Ping):
Server side (serveStream):
The [0x00, 0x00] marker is safe because it represents a zero-length object, which cannot occur in normal session traffic (valid SignedObjects always have length > 0).
Yamux sessions continue to use the built-in yamux.Ping().