Skip to content

fix(signature): validate signing_secret is a non-empty string #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 2 commits into from
Jun 3, 2026
+52 −0

Merge branch 'main' into empty-signing-secret

4446698
Select commit
Loading
Failed to load commit list.
Merged

fix(signature): validate signing_secret is a non-empty string #1884

Merge branch 'main' into empty-signing-secret
4446698
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 3, 2026 in 1s

84.14% (+0.01%) compared to 7e3b2dd

View this Pull Request on Codecov

84.14% (+0.01%) compared to 7e3b2dd

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.14%. Comparing base (7e3b2dd) to head (4446698).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1884      +/-   ##
==========================================
+ Coverage   84.13%   84.14%   +0.01%     
==========================================
  Files         117      117              
  Lines       13346    13356      +10     
==========================================
+ Hits        11228    11238      +10     
  Misses       2118     2118

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov