fix: wrap column names in generated SQL schema files#89
Open
rokf wants to merge 1 commit intosmart-data-models:masterfrom
Open
fix: wrap column names in generated SQL schema files#89rokf wants to merge 1 commit intosmart-data-models:masterfrom
rokf wants to merge 1 commit intosmart-data-models:masterfrom
Conversation
Properties in some of the Smart Data Models have the same name as reserved keywords in SQL. The SQL schema files that were generated before this fix were therefore broken and couldn't be applied to a database. This fix quotes all of the column names in the generated SQL schema file, which prevents the issue from happening. Issue: smart-data-models#73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properties in some of the Smart Data Models
have the same name as reserved keywords in SQL.
The SQL schema files that were generated before
this fix were therefore broken and couldn't
be applied to a database.
This fix quotes all of the column names
in the generated SQL schema file, which
prevents the issue from happening.
Issue: #73