-
Notifications
You must be signed in to change notification settings - Fork 10
Get message IDs by TX (method + CLI command) #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PabloMansanet
wants to merge
4
commits into
retrieve_from_api_by_ID
Choose a base branch
from
get-messages-in-tx
base: retrieve_from_api_by_ID
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coverage Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking ticket here.
This PR is stacked on top of the
getMessageByIdone. I tested it manually against a locally hosted instance of the latest API.Thoughts on ordering: The ticket specifies
TO-BE: Use the API to return the messageID(s) sorted by log index for a given transaction hash. However, log data isn't accessible through the API, so it's not possible to enforce this specific order without enrichment by the layers above.This method then returns all messageIDs associated with a hash, but in the API's ordering.
Also, I made the assumption that pagination for this response is impossible (how could we have 100+ message IDs for a single hash?) and throw an error in case it happens, but feel free to challenge this if there are edge cases I don't know about in non-EVMs or similar.