Drain queue before emitting connect event. #5259
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrachequesne
pushed a commit
that referenced
this pull request
Dec 22, 2025
When the `retries` option was enabled, an event emitted in the "connect" handler would be sent twice. Related: #5258
Member
|
Merged as d19928e. Sorry for the (very) late merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Fixes: #5258
Current behavior
When the retries option is enabled in the Socket.IO client, the client emits the initial event twice inside the 'connect' handler.
New behavior
The event inside the 'connect' handler should be emitted only once, regardless of whether the retries option is enabled or disabled.
Other information (e.g. related issues)
We can drain the queue before emitting the connect event.