[FEM.Elastic] Cache stiffness matrices before computations#6069
Open
fredroy wants to merge 2 commits intosofa-framework:masterfrom
Open
[FEM.Elastic] Cache stiffness matrices before computations#6069fredroy wants to merge 2 commits intosofa-framework:masterfrom
fredroy wants to merge 2 commits intosofa-framework:masterfrom
Conversation
Extract assembled stiffness matrices into a separate contiguous buffer (m_assembledStiffnessMatrices) to replace getReadAccessor calls on Data<vector<FactorizedElementStiffness>> inside parallel forEachRange lambdas. The read accessor acquires a shared lock on the Data object, causing contention across threads and effectively serializing the parallel work during CG iterations. Using a direct const reference to a plain vector eliminates this synchronization bottleneck (~3x speedup in parallel mode). As a secondary benefit, the contiguous buffer only stores the assembled 24x24 matrices (~4.6 KB each) rather than the full FactorizedElementStiffness structs (~14 KB each), improving cache utilization.
Contributor
Author
|
[ci-build][with-all-tests] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[with-all-tests]
Based on
Cache the assembled stiffness matrices into a flat vector.
-> Cache friendly so supposedly faster
Results: depends on the OS/CPU:
on macOS the speed up is quite high (~3x faster) both sequential and parallel, for both hexa and tetra
but on linux/intel the speed up is only for hexa (???) 🤔
Benches: (on Validation/cantilever_beam with 10x10x60 grid)
macOS on M3Pro ( 12 P + 4E cores)
before:
after:
Linux on i7 13700K ( 8 P + 8E cores)
before:
after:
Explanation by Claude on the why the difference between cpus (seems plausible 🫠)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if