Skip to content

[all] Apply template method pattern to SOFA Core#6074

Open
bakpaul wants to merge 12 commits intomasterfrom
2026_template_method_full
Open

[all] Apply template method pattern to SOFA Core#6074
bakpaul wants to merge 12 commits intomasterfrom
2026_template_method_full

Conversation

@bakpaul
Copy link
Copy Markdown
Contributor

@bakpaul bakpaul commented Apr 8, 2026 •
edited
Loading

The big chunk being BaseComponent, it'll be done in a second PR after this one is merged. All commit of this PR is an open PR that'll be closed afterwards. It is better to have one full PR then multiple small ones. Here is a complete list:

[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/327]
[ci-depends-on https://github.com/sofa-framework/SofaSphFluid/pull/20]
[ci-depends-on https://github.com/sofa-framework/PluginExample/pull/16]

[force-full-build]
[with-all-tests]

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

bakpaul added 2 commits April 8, 2026 17:11
@bakpaul
Squashed merge of PR #5481 :
0f633a2 
commit 68251eb
Author: Paul Baksic <paul.baksic@outlook.fr>
Date:   Wed Apr 8 16:51:03 2026 +0200

    Apply reviews

commit a5e0a9e
Author: Paul Baksic <paul.baksic@outlook.fr>
Date:   Wed Apr 8 15:29:18 2026 +0200

    Fig distance grid

commit bb0c921
Author: Paul Baksic <paul.baksic@outlook.fr>
Date:   Wed Apr 8 11:35:50 2026 +0200

    Fix compilationa fter merge

commit 070718d
Author: Paul Baksic <paul.baksic@outlook.fr>
Date:   Tue Jan 6 10:50:31 2026 +0100

    Apply modified patch from #5481 to take refactoring into account

    Co-authored-by: lbinria <77280433+lbinria@users.noreply.github.com>
@bakpaul
Squashed merge of PR #5478 :
0eeb649 
commit b2131c3
Merge: 402de71 25a096d
Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Date:   Wed Apr 8 14:23:26 2026 +0200

    Merge branch 'master' into 2025_sprintsed_baseconstraintset

commit 402de71
Author: hugtalbot <hugo.talbot@inria.fr>
Date:   Tue Jan 6 12:25:45 2026 +0100

    force push - Apply template method design pattern to BaseConstraintSet
@bakpaul bakpaul added pr: status wip Development in the pull-request is still in progress pr: experimental Demonstrate an experimental feature pr: highlighted in next release Highlight this contribution in the notes of the upcoming release labels Apr 8, 2026
@sofa-framework sofa-framework deleted a comment from github-actions bot Apr 8, 2026
@sofa-framework sofa-framework deleted a comment from github-actions bot Apr 8, 2026
@sofa-framework sofa-framework deleted a comment from github-actions bot Apr 8, 2026
@bakpaul bakpaul added the pr: enhancement About a possible enhancement label Apr 8, 2026
@sofa-framework sofa-framework deleted a comment from github-actions bot Apr 8, 2026
@sofa-framework sofa-framework deleted a comment from sofabot Apr 8, 2026
@bakpaul
Copy link
Copy Markdown
Contributor Author

bakpaul commented Apr 8, 2026

[ci-build]
[force-full-build]
[with-all-tests]

bakpaul added 2 commits April 8, 2026 17:53
@bakpaul
Squashed merge of PR #5477
f14bf71 
commit 35f6e66
Merge: 8c44d43 25a096d
Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Date:   Wed Apr 8 14:34:48 2026 +0200

    Merge branch 'master' into 2025_sprintsed_BaseProjectiveConstraintSet

commit 8c44d43
Merge: 83574d0 fb6ac6c
Author: Hugo <hugo.talbot@sofa-framework.org>
Date:   Tue Jan 6 10:37:46 2026 +0100

    Merge branch 'master' into 2025_sprintsed_BaseProjectiveConstraintSet

commit 83574d0
Author: Paul Breugnot <paul.breugnot@inria.fr>
Date:   Wed May 14 12:52:39 2025 +0200

    TODO (SPRINT SED 2025) comments and v25.12 warnings

commit 81ac621
Author: Paul Breugnot <paul.breugnot@inria.fr>
Date:   Wed May 14 12:39:39 2025 +0200

    Applies template method pattern to projectMatrix() in BaseProjectiveConstraintSet

commit 2a276c0
Author: Paul Breugnot <paul.breugnot@inria.fr>
Date:   Wed May 14 10:46:02 2025 +0200

    Applies template method pattern to applyConstraint() in BaseProjectiveConstraintSet

commit 051ef10
Author: Paul Breugnot <paul.breugnot@inria.fr>
Date:   Wed May 14 10:15:34 2025 +0200

    Applies template method pattern to projectPosition() in BaseProjectiveConstraintSet

commit 53bdd16
Author: Paul Breugnot <paul.breugnot@inria.fr>
Date:   Wed May 14 10:01:02 2025 +0200

    Applies template method pattern to projectVelocity() in BaseProjectiveConstraintSet

commit e781ec9
Author: Paul Breugnot <paul.breugnot@inria.fr>
Date:   Wed May 14 09:44:19 2025 +0200

    Applies template method pattern to projectJacobianMatrix() in BaseProjectiveConstraintSet

commit e88439c
Author: Paul Breugnot <paul.breugnot@inria.fr>
Date:   Wed May 14 09:21:09 2025 +0200

    Revert "ProjectiveConstraintSet and PairInteractionProjectiveConstraintSet: projectResponse() -> doProjectResponse()"

    This reverts commit c978190, as we
    finally do not want to touch to methods in children of
    BaseProjectiveConstraintSet, so we keep projectResponse() overloads in
    those classes.

commit dd7a394
Author: Paul Breugnot <paul.breugnot@inria.fr>
Date:   Tue May 13 16:52:14 2025 +0200

    ProjectiveConstraintSet and PairInteractionProjectiveConstraintSet: projectResponse() -> doProjectResponse()

    Template method pattern not yet applied for those overloads of
    BaseProjectiveConstraintSet methods.

commit 6546436
Author: Paul Breugnot <paul.breugnot@inria.fr>
Date:   Tue May 13 14:28:18 2025 +0200

    Applies template method pattern to projectResponse() in BaseProjectiveConstraintSet

commit 3db809c
Author: Paul Breugnot <paul.breugnot@inria.fr>
Date:   Tue May 13 14:08:08 2025 +0200

    Applies template method pattern to getModels() in BaseProjectiveConstraintSet
@bakpaul
Squashed merge of PR #5435
86974fe 
commit 8590a63
Author: Hugo <hugo.talbot@sofa-framework.org>
Date:   Tue Jan 6 11:06:28 2026 +0100

    Apply suggestions from code review

    Co-authored-by: Damien Marchal <damien.marchal@univ-lille1.fr>

commit 4af4543
Author: Olivier Rochel <olivier.rochel@inria.fr>
Date:   Mon May 12 14:17:12 2025 +0200

    BaseRotationFinder: set template method pattern for BaseRotationFinder::getRotations
@sofa-framework sofa-framework deleted a comment from sofabot Apr 8, 2026
@sofa-framework sofa-framework deleted a comment from sofabot Apr 8, 2026
@sofa-framework sofa-framework deleted a comment from sofabot Apr 8, 2026
hugtalbot added 2 commits April 8, 2026 18:02
@hugtalbot
Squashed merged of PR #5436
ef49cb8 
commit d65491c
Merge: d54fa37 25a096d
Author: Hugo <hugo.talbot@sofa-framework.org>
Date:   Wed Apr 8 11:09:03 2026 +0200

    Merge branch 'master' into 2025_sprintsed_BaseSimulationExporter

commit d54fa37
Merge: bea6be9 fb6ac6c
Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Date:   Tue Jan 6 11:41:07 2026 +0100

    Merge branch 'master' into 2025_sprintsed_BaseSimulationExporter

commit bea6be9
Author: Hugo <hugo.talbot@sofa-framework.org>
Date:   Mon May 12 15:05:40 2025 +0200

    Apply suggestions from code review

commit e60d686
Author: lbinria <77280433+lbinria@users.noreply.github.com>
Date:   Mon May 12 14:43:45 2025 +0200

    [Framework] Apply template method design pattern to BaseSimulationExporter
@hugtalbot
Squashed merge of PR #5434
829b653 
commit d6940e2
Merge: 5344121 25a096d
Author: Hugo <hugo.talbot@sofa-framework.org>
Date:   Wed Apr 8 10:25:03 2026 +0200

    Merge branch 'master' into 2025_sedsprint_BaseAnimationLoop

commit 5344121
Author: Hugo <hugo.talbot@sofa-framework.org>
Date:   Tue Jan 6 11:18:14 2026 +0100

    Apply suggestions from code review

    Co-authored-by: Damien Marchal <damien.marchal@univ-lille1.fr>

commit f4b274e
Merge: 2d3c39d fb6ac6c
Author: Hugo <hugo.talbot@sofa-framework.org>
Date:   Tue Jan 6 11:17:52 2026 +0100

    Merge branch 'master' into 2025_sedsprint_BaseAnimationLoop

commit 2d3c39d
Author: Théo BL <theo.biasutto-lervat@inria.fr>
Date:   Mon May 12 13:58:29 2025 +0200

    feat(sed_sprint): apply template method to BaseAnimationLoop::step
@hugtalbot hugtalbot marked this pull request as draft April 8, 2026 16:13
@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Apr 8, 2026
@hugtalbot
Squashed merge of PR #5433
d30395e 
commit 9fb92fb
Author: hugtalbot <hugo.talbot@sofa-framework.org>
Date:   Wed Apr 8 17:53:23 2026 +0200

    Remove PipelineImpl which is now unused and incompatible with new API

commit f06571f
Author: hugtalbot <hugo.talbot@sofa-framework.org>
Date:   Wed Apr 8 17:50:18 2026 +0200

    Update to apply BaseSubCollisionPipeline newly introduced and update Pipeline too

commit 5c8c693
Merge: 173996b 25a096d
Author: Hugo <hugo.talbot@sofa-framework.org>
Date:   Wed Apr 8 10:21:27 2026 +0200

    Merge branch 'master' into 2025_sprintsed_pipeline

commit 173996b
Merge: 6a5464a fb6ac6c
Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Date:   Tue Jan 6 11:41:44 2026 +0100

    Merge branch 'master' into 2025_sprintsed_pipeline

commit 6a5464a
Author: bakpaul <paul.baksic@outlook.fr>
Date:   Mon May 12 13:48:05 2025 +0200

    Move templated methods intpo right class
@hugtalbot hugtalbot marked this pull request as ready for review April 8, 2026 16:19
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

[ci-depends-on] detected.

To unlock the merge button, you must

@sofa-framework sofa-framework deleted a comment from sofabot Apr 8, 2026
@sofa-framework sofa-framework deleted a comment from sofabot Apr 8, 2026
@sofa-framework sofa-framework deleted a comment from sofabot Apr 8, 2026
@hugtalbot hugtalbot changed the title [all] Apply template method patern to the Core [all] Apply template method pattern to SOFA Core Apr 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

[ci-depends-on] detected.

To unlock the merge button, you must

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented Apr 10, 2026

[ci-depends-on] detected during build #8.

To unlock the merge button, you must

@hugtalbot
Squashed merge of PR #5471
754ced7 
commit 9ffc78f
Merge: 0059ef6 25a096d
Author: Hugo <hugo.talbot@sofa-framework.org>
Date:   Wed Apr 8 18:53:35 2026 +0200

    Merge branch 'master' into 2025_sprintsed_BaseCamera

commit 0059ef6
Merge: bf53c56 fb6ac6c
Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Date:   Tue Jan 6 11:21:01 2026 +0100

    Merge branch 'master' into 2025_sprintsed_BaseCamera

commit bf53c56
Author: lbinria <77280433+lbinria@users.noreply.github.com>
Date:   Wed May 14 10:44:48 2025 +0200

    [Framework] Apply template method design pattern to BaseCamera
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

[ci-depends-on] detected.

To unlock the merge button, you must

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented Apr 10, 2026

[ci-depends-on] detected during build #9.

To unlock the merge button, you must

@bakpaul
Squashed merge of PR #5439
c1b6cba 
commit 370b6c4
Merge: 8d4aacd 912335e
Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Date:   Fri Apr 10 09:25:36 2026 +0200

    Merge branch 'master' into 2025_sedsprint_BaseMaterial

commit 8d4aacd
Merge: a099baa fb6ac6c
Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Date:   Tue Jan 6 11:42:09 2026 +0100

    Merge branch 'master' into 2025_sedsprint_BaseMaterial

commit a099baa
Author: Théo BL <theo.biasutto-lervat@inria.fr>
Date:   Mon May 12 15:22:49 2025 +0200

    refacto: ensure naming consistency

commit e20ce58
Author: Théo BL <theo.biasutto-lervat@inria.fr>
Date:   Mon May 12 15:17:53 2025 +0200

    feat(sed_sprint): apply template method to BaseMaterial
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

[ci-depends-on] detected.

To unlock the merge button, you must

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented Apr 10, 2026

[ci-depends-on] detected during build #10.

To unlock the merge button, you must

@bakpaul
Squashed merge of PR #5441
258af4a 
commit a929769
Merge: e61cdb4 25a096d
Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Date:   Wed Apr 8 14:48:29 2026 +0200

    Merge branch 'master' into 2025_sprintsed_BaseVisualStyle

commit e61cdb4
Merge: 16ac85d fb6ac6c
Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Date:   Tue Jan 6 11:40:42 2026 +0100

    Merge branch 'master' into 2025_sprintsed_BaseVisualStyle

commit 16ac85d
Author: lbinria <77280433+lbinria@users.noreply.github.com>
Date:   Mon May 12 15:19:25 2025 +0200

    [Framework] Apply template method design pattern to BaseVisualStyle
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

[ci-depends-on] detected.

To unlock the merge button, you must

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented Apr 10, 2026

[ci-depends-on] detected during build #11.

To unlock the merge button, you must

@bakpaul
Squashed merge of PR #5443
5e2b474 
commit 25bdd97
Merge: 48fa61d 912335e
Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Date:   Fri Apr 10 09:39:49 2026 +0200

    Merge branch 'master' into 2025_sprintsed_BehaviorModel

commit 48fa61d
Merge: 25ab6f4 fb6ac6c
Author: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
Date:   Tue Jan 6 11:34:38 2026 +0100

    Merge branch 'master' into 2025_sprintsed_BehaviorModel

commit 25ab6f4
Author: lbinria <77280433+lbinria@users.noreply.github.com>
Date:   Mon May 12 16:53:02 2025 +0200

    [Framework] Apply template method design pattern to BehaviorModel
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

[ci-depends-on] detected.

To unlock the merge button, you must

@sofabot
Copy link
Copy Markdown
Collaborator

sofabot commented Apr 10, 2026

[ci-depends-on] detected during build #12.

To unlock the merge button, you must

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

[ci-depends-on] detected.

To unlock the merge button, you must

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: enhancement About a possible enhancement pr: experimental Demonstrate an experimental feature pr: highlighted in next release Highlight this contribution in the notes of the upcoming release pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bakpaul @sofabot @hugtalbot